Bug 243750 - [merge-queue] validate-commit-message step rejects reviewers if spelling isn't an exact match with contributors.json
Summary: [merge-queue] validate-commit-message step rejects reviewers if spelling isn'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-09 14:14 PDT by Ryan Haddad
Modified: 2022-08-09 16:21 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-08-09 14:14:24 PDT 
The validate-commit-message step rejects reviewers if spelling isn't an exact match with contributors.json, e.g. here were Geoff Garen != Geoffrey Garen: https://ews-build.webkit.org/#/builders/74/builds/2279

As discussed on slack, we should drop this validation since committers are trusted people.
Comment 1 Radar WebKit Bug Importer 2022-08-09 14:14:40 PDT 
<rdar://problem/98405285>
Comment 2 Aakash Jain 2022-08-09 15:33:37 PDT 
PR: https://github.com/WebKit/WebKit/pull/3168
Comment 3 EWS 2022-08-09 16:21:13 PDT 
Committed 253275@main (a25d41d0d20f): <https://commits.webkit.org/253275@main>

Reviewed commits have been landed. Closing PR #3168 and removing active labels.