WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
243750
[merge-queue] validate-commit-message step rejects reviewers if spelling isn't an exact match with contributors.json
https://bugs.webkit.org/show_bug.cgi?id=243750
Summary
[merge-queue] validate-commit-message step rejects reviewers if spelling isn'...
Ryan Haddad
Reported
2022-08-09 14:14:24 PDT
The validate-commit-message step rejects reviewers if spelling isn't an exact match with contributors.json, e.g. here were Geoff Garen != Geoffrey Garen:
https://ews-build.webkit.org/#/builders/74/builds/2279
As discussed on slack, we should drop this validation since committers are trusted people.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-08-09 14:14:40 PDT
<
rdar://problem/98405285
>
Aakash Jain
Comment 2
2022-08-09 15:33:37 PDT
PR:
https://github.com/WebKit/WebKit/pull/3168
EWS
Comment 3
2022-08-09 16:21:13 PDT
Committed
253275@main
(a25d41d0d20f): <
https://commits.webkit.org/253275@main
> Reviewed commits have been landed. Closing PR #3168 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug