NEW 243748
[Filters] Move the static createEffect functions to the FilterOperation classes 
https://bugs.webkit.org/show_bug.cgi?id=243748
Summary [Filters] Move the static createEffect functions to the FilterOperation classes
Said Abou-Hallawa
Reported 2022-08-09 13:19:24 PDT
The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static createEffect functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call createReferenceFilter() from CSSFilter::buildFilterFunctions() as a special case.
Attachments
Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2022-08-09 13:35:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3165
Radar WebKit Bug Importer
Comment 2 2022-08-16 13:20:34 PDT
<rdar://problem/98745167>
Note You need to log in before you can comment on or make changes to this bug.