Bug 243741 - [Filters] Move the static calculateOutsets functions to the FilterOperation classes
Summary: [Filters] Move the static calculateOutsets functions to the FilterOperation c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-09 11:54 PDT by Said Abou-Hallawa
Modified: 2022-08-09 22:50 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-08-09 11:54:22 PDT 
The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static calculateOutsets functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call calculateReferenceFilterOutsets() from CSSFilter::calculateOutsets() as a special case.
Comment 1 Said Abou-Hallawa 2022-08-09 12:05:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3160
Comment 2 EWS 2022-08-09 22:49:28 PDT 
Committed 253283@main (831f062e4ac0): <https://commits.webkit.org/253283@main>

Reviewed commits have been landed. Closing PR #3160 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-08-09 22:50:18 PDT 
<rdar://problem/98427858>