Bug 24369 - Chromium Linux: change some metrics to better match Windows
Summary: Chromium Linux: change some metrics to better match Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Adam Langley
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-04 14:36 PST by Adam Langley
Modified: 2009-03-04 16:57 PST (History)
0 users

See Also:


Attachments
patch (2.39 KB, patch)
2009-03-04 14:39 PST, Adam Langley
no flags Details | Formatted Diff | Diff
patch (3.67 KB, patch)
2009-03-04 15:26 PST, Adam Langley
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-03-04 14:36:28 PST
Change some metrics to better match Windows after r41416. Aesthetically this may be worse, but web-compat is king.
Comment 1 Adam Langley 2009-03-04 14:39:04 PST
Created attachment 28285 [details]
patch
Comment 2 Adam Langley 2009-03-04 15:26:29 PST
Created attachment 28286 [details]
patch
Comment 3 Darin Fisher (:fishd, Google) 2009-03-04 16:11:37 PST
Comment on attachment 28286 [details]
patch

>+        Chromium Linux: change some metrics to better match Windows after
>+        r41416. Aesthetically this may be worse, but web-compat is king.

it is good practice to list some of the tests corresponding to this change.
it sounds like you are making some tests pass now with this change, so those
would be good tests to list here.  i think the syntax goes something like:

  Test: fast/dom/fooBar.html


otherwise, LGTM
Comment 4 Adam Langley 2009-03-04 16:15:47 PST
I rebaselined approx 3900 tests after this change, so I figured it would be better not to list them :)
Comment 5 Eric Seidel (no email) 2009-03-04 16:57:31 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp
	M	WebCore/rendering/RenderThemeChromiumLinux.cpp
Committed r41437