WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24369
Chromium Linux: change some metrics to better match Windows
https://bugs.webkit.org/show_bug.cgi?id=24369
Summary
Chromium Linux: change some metrics to better match Windows
Adam Langley
Reported
2009-03-04 14:36:28 PST
Change some metrics to better match Windows after
r41416
. Aesthetically this may be worse, but web-compat is king.
Attachments
patch
(2.39 KB, patch)
2009-03-04 14:39 PST
,
Adam Langley
no flags
Details
Formatted Diff
Diff
patch
(3.67 KB, patch)
2009-03-04 15:26 PST
,
Adam Langley
fishd
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Langley
Comment 1
2009-03-04 14:39:04 PST
Created
attachment 28285
[details]
patch
Adam Langley
Comment 2
2009-03-04 15:26:29 PST
Created
attachment 28286
[details]
patch
Darin Fisher (:fishd, Google)
Comment 3
2009-03-04 16:11:37 PST
Comment on
attachment 28286
[details]
patch
>+ Chromium Linux: change some metrics to better match Windows after >+
r41416
. Aesthetically this may be worse, but web-compat is king.
it is good practice to list some of the tests corresponding to this change. it sounds like you are making some tests pass now with this change, so those would be good tests to list here. i think the syntax goes something like: Test: fast/dom/fooBar.html otherwise, LGTM
Adam Langley
Comment 4
2009-03-04 16:15:47 PST
I rebaselined approx 3900 tests after this change, so I figured it would be better not to list them :)
Eric Seidel (no email)
Comment 5
2009-03-04 16:57:31 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp M WebCore/rendering/RenderThemeChromiumLinux.cpp Committed
r41437
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug