Bug 243617 - [git-webkit] Improve the error message when PR fails to create
Summary: [git-webkit] Improve the error message when PR fails to create
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Youssef Soliman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-05 16:51 PDT by Tim Nguyen (:ntim)
Modified: 2022-08-23 14:48 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-08-05 16:51:14 PDT
Sometimes the PR fails to create because the branch needs rebasing, but the error message is:

```
Validation failed when creating pull request
Does a pull request against this branch already exist?
```
Comment 1 Radar WebKit Bug Importer 2022-08-05 16:51:34 PDT
<rdar://problem/98218733>
Comment 2 Tim Nguyen (:ntim) 2022-08-05 17:13:36 PDT
actually my PR didn't fail because of rebasing, it was because the commit message was too long:

{'message': 'Validation Failed', 'errors': [{'resource': 'Issue', 'code': 'custom', 'field': 'body', 'message': 'body is too long (maximum is 65536 characters)'}], 'documentation_url': 'https://docs.github.com/rest/reference/pulls#create-a-pull-request'}
Comment 3 Tim Nguyen (:ntim) 2022-08-05 17:37:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3068
Comment 4 Youssef Soliman 2022-08-05 18:12:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3069
Comment 5 EWS 2022-08-15 09:46:19 PDT
Committed 253428@main (b33f467f3096): <https://commits.webkit.org/253428@main>

Reviewed commits have been landed. Closing PR #3069 and removing active labels.
Comment 6 EWS 2022-08-23 14:48:48 PDT
Committed 252432.225@safari-7614-branch (7bbd78c8b752): <https://commits.webkit.org/252432.225@safari-7614-branch>

Reviewed commits have been landed. Closing PR #32 and removing active labels.