Bug 243562 - Make '-webkit-background-size' a legacy shorthand
Summary: Make '-webkit-background-size' a legacy shorthand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks: 240341
  Show dependency treegraph
 
Reported: 2022-08-04 15:24 PDT by Tim Nguyen (:ntim)
Modified: 2022-11-13 02:54 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-08-04 15:24:15 PDT
This test checks that setting various properties to the same value as the user agent stylesheet does not change the appearance.

We fail this check, potentially because our borderAndBackgroundEquals check does not cover enough properties.
Comment 1 Radar WebKit Bug Importer 2022-08-04 15:24:25 PDT
<rdar://problem/98151497>
Comment 2 Aditya Keerthi 2022-08-07 22:23:46 PDT
One of the issues is: https://github.com/web-platform-tests/wpt/issues/35333.

The other issue is that the list of "fallback-props" in https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute-kind-widget-no-fallback-props-001.html, does not include `-webkit-background-size`, in addition to `background-size`, causing the `borderAndBackgroundEquals` check to fail, dropping native appearance.

The test and the spec likely need to be updated.
Comment 3 Tim Nguyen (:ntim) 2022-08-08 21:37:41 PDT
(In reply to Aditya Keerthi from comment #2)
> The other issue is that the list of "fallback-props" in
> https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute-
> kind-widget-no-fallback-props-001.html, does not include
> `-webkit-background-size`, in addition to `background-size`, causing the
> `borderAndBackgroundEquals` check to fail, dropping native appearance.

The proper way to fix this would be making `-webkit-background-size` a legacy shorthand of `background-size` rather than implementing it as a related property. An example of this is bug 104805.
Comment 4 Tim Nguyen (:ntim) 2022-08-09 14:02:24 PDT Comment hidden (obsolete)
Comment 5 Aditya Keerthi 2022-08-12 17:24:23 PDT
I have a patch in progress to make `-webkit-background-size` a legacy shorthand. This actually makes appearance behave correctly, however, the test still fails.

We will also need to fix the intrinsic margins issue (https://bugs.webkit.org/show_bug.cgi?id=107380) in order to get this test passing.

I confirmed that with my background-size patch, and with Chris' patch in https://bugs.webkit.org/show_bug.cgi?id=107380, this test finally passes.
Comment 6 Aditya Keerthi 2022-08-16 13:26:25 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3372
Comment 7 EWS 2022-09-27 11:16:29 PDT
Committed 254925@main (856140e9a06f): <https://commits.webkit.org/254925@main>

Reviewed commits have been landed. Closing PR #3372 and removing active labels.