RESOLVED FIXED 243548
[ews] merge-queue fails to find reviewer on GitHub PRs with lots of review activity 
https://bugs.webkit.org/show_bug.cgi?id=243548
Summary [ews] merge-queue fails to find reviewer on GitHub PRs with lots of review ac...
Ryan Haddad
Reported 2022-08-04 09:15:10 PDT
merge-queue fails to find reviewer on GitHub PRs with lots of review activity because our tooling doesn't handle the case where API results become paginated This was seen with the following PRs: https://github.com/WebKit/WebKit/pull/2741 https://github.com/WebKit/WebKit/pull/2417
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-04 09:15:37 PDT
<rdar://problem/98129710>
Aakash Jain
Comment 2 2022-08-04 09:18:38 PDT
For reference, corresponding buildbot builds with the issue: https://ews-build.webkit.org/#/builders/74/builds/2040 https://ews-build.webkit.org/#/builders/74/builds/2175 GitHub api which Merge-Queue use (e.g.: https://api.github.com/repos/Webkit/WebKit/pulls/2741/reviews) wasn't listing the APPROVED state since it got paginated.
Jonathan Bedard
Comment 3 2022-11-10 11:24:53 PST
Pull request: https://github.com/WebKit/WebKit/pull/6355
EWS
Comment 4 2022-11-16 14:42:54 PST
Committed 256752@main (42fd020fc0c3): <https://commits.webkit.org/256752@main> Reviewed commits have been landed. Closing PR #6355 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.