Bug 243534 – [CSS contain] Fix handling of layout/paint containment with internal ruby boxes

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rob Buis]

Fix handling of layout/paint containment with ruby.

[Rob Buis]

Created attachment 461396 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Tim Nguyen (:ntim)]

Comment on attachment 461396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461396&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html:7
> +<meta name="fuzzy" content="maxDifference=0-3; totalPixels=0-6738" />

Why do we need so many fuzzy pixels?

[Rob Buis]

Comment on attachment 461396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461396&action=review

>> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html:7
>> +<meta name="fuzzy" content="maxDifference=0-3; totalPixels=0-6738" />
> 
> Why do we need so many fuzzy pixels?

Quite sure we do not need that many, I had a 1 pixel difference locally. However also locally no fuzzy value for me fixed the test. So now I am wondering what the bots will say, let's see!

[Rob Buis]

Created attachment 461398 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/98153015>

[Tim Nguyen (:ntim)]

Comment on attachment 461398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461398&action=review

> Source/WebCore/rendering/RenderLayer.cpp:584
> +    return !renderer().style().hasAutoUsedZIndex() || renderer().shouldApplyLayoutOrPaintContainment({ Containment::Layout, Containment::Paint }) | isRenderViewLayer();

I don't think you wanted to do the bitwise operator |

|| ?

[Rob Buis]

Created attachment 461492 [details]
Patch

[Rob Buis]

Comment on attachment 461398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461398&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:584
>> +    return !renderer().style().hasAutoUsedZIndex() || renderer().shouldApplyLayoutOrPaintContainment({ Containment::Layout, Containment::Paint }) | isRenderViewLayer();
> 
> I don't think you wanted to do the bitwise operator |
> 
> || ?

Well spotted, thnx! Fixed.

[EWS]

No reviewer information in commit message, blocking PR #None

[Rob Buis]

Created attachment 461543 [details]
Patch

[Rob Buis]

Created attachment 461544 [details]
Patch

[EWS]

Committed 253354@main (6d0e1e4280d9): <https://commits.webkit.org/253354@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461544 [details].