Bug 243499 - [LBSE] Add support for 'image' elements
Summary: [LBSE] Add support for 'image' elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on: 243493 243497 243498
Blocks: 90738
  Show dependency tree / graph
 
Reported: 2022-08-03 10:08 PDT by Nikolas Zimmermann
Modified: 2022-08-31 11:47 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-08-03 10:08:26 PDT 
Add support for the last missing SVG element, that is not a resource (pattern / gradient / clipPath / masker / marker): <image>.
Comment 1 Radar WebKit Bug Importer 2022-08-10 10:09:16 PDT 
<rdar://problem/98457550>
Comment 2 Nikolas Zimmermann 2022-08-22 04:51:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3532
Comment 3 EWS 2022-08-25 14:13:22 PDT 
Committed 253793@main (4b8776daaa57): <https://commits.webkit.org/253793@main>

Reviewed commits have been landed. Closing PR #3532 and removing active labels.
Comment 4 Michael Catanzaro 2022-08-31 11:47:35 PDT 
Hi Nikolas, can you fix this warning please?

[1118/2033] Building CXX object Source/WebCore/CMakeFiles/...ivedSources/unified-sources/UnifiedSource-8feba646-9.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk3/WebCore/DerivedSources/unified-sources/UnifiedSource-8feba646-9.cpp:2:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/svg/SVGImageElement.cpp: In member function ‘virtual void WebCore::SVGImageElement::svgAttributeChanged(const WebCore::QualifiedName&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/svg/SVGImageElement.cpp:113:23: warning: unused variable ‘image’ [-Wunused-variable]
  113 |             if (auto* image = dynamicDowncast<RenderSVGImage>(renderer()))
      |                       ^~~~~

I'm not certain whether you want to do:

#if ENABLE(LAYER_BASED_SVG_ENGINE)
            if (dynamicDowncast<RenderSVGImage>(renderer()))
                updateSVGRendererForElementChange();
#endif

Or whether you want to do:

#if ENABLE(LAYER_BASED_SVG_ENGINE)
            updateSVGRendererForElementChange();
#endif

So I'll just leave it to you, OK?