WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
243470
[ews-build] Improve error message when Merge-Queue fails to find reviewer
https://bugs.webkit.org/show_bug.cgi?id=243470
Summary
[ews-build] Improve error message when Merge-Queue fails to find reviewer
Aakash Jain
Reported
2022-08-02 15:10:04 PDT
In
https://ews-build.webkit.org/#/builders/74/builds/2040
failed and complaint that "Commit message contains (OOPS!)". However, it was expected that commit message would have OOPS in it, since PR was approved throughGitHub UI, and Merge-Queue should instead remove the OOPS. We should improve the error message when Merge-Queue fails to find reviewer.
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2022-08-03 06:50:41 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2976
EWS
Comment 2
2022-08-03 10:40:48 PDT
Committed
253083@main
(fd260f7fe6d3): <
https://commits.webkit.org/253083@main
> Reviewed commits have been landed. Closing PR #2976 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-08-03 10:41:32 PDT
<
rdar://problem/98062999
>
Aakash Jain
Comment 4
2022-08-04 04:36:46 PDT
Working fine. e.g.:
https://ews-build.webkit.org/#/builders/74/builds/2175
GitHub comment is also updated to indicate missing reviewer now:
https://github.com/WebKit/WebKit/pull/2417#issuecomment-1205136296
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug