Bug 24346 - Remove Gears workaround in HTMLObjectElement.cpp
Summary: Remove Gears workaround in HTMLObjectElement.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Jeremy Moskovich
Depends on: 27775 45049
  Show dependency treegraph
Reported: 2009-03-04 02:02 PST by Jeremy Moskovich
Modified: 2010-11-29 08:47 PST (History)
5 users (show)

See Also:

Patch (1.53 KB, patch)
2010-11-29 02:55 PST, Jeremy Moskovich
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2009-03-04 02:02:58 PST
This bug is to track removal of the temporary workaround for Gears compatibility in WebKit (see https://bugs.webkit.org/show_bug.cgi?id=24215).

Closing this bug should involve removing the workaround in favor of a long term solution.

The underlying problem is that current users of gears use a standard gears_init.js that relies on a plugin loading if it's display attribute is set to hidden.
Comment 1 Eric Seidel (no email) 2010-09-01 02:23:07 PDT
What's the status here?  This code is still in the codebase.
Comment 2 Simon Fraser (smfr) 2010-09-01 08:19:44 PDT
The plan is to make plugins not go away when an element has display:none. Not sure if we have a bugzilla bug on that.
Comment 3 Simon Fraser (smfr) 2010-09-01 11:35:47 PDT
See bug 27775.
Comment 4 Jeremy Moskovich 2010-11-29 02:55:34 PST
Created attachment 75005 [details]
Comment 5 Eric Seidel (no email) 2010-11-29 07:25:35 PST
Comment on attachment 75005 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=75005&action=review

I think we can safely remove the entire rendererIsNeeded() call.  I don't see any parent implementations preventing creation of renderers when a document doesn't have a frame, but I believe that to be the case.  Frameless documents won't have a FrameView, thus won't be rendered is my understanding.  I think this whole override can be removed unless we have a test which proves otherwise.

> WebCore/html/HTMLObjectElement.cpp:289
>      if (!frame)
>          return false;

Are we sure this is still needed?
Comment 6 Eric Seidel (no email) 2010-11-29 07:31:20 PST
I'd rather see you commit this by hand and remove the whole function (or post a new patch to do so).  I don't believe the !frame check has any utility.
Comment 7 Jeremy Moskovich 2010-11-29 07:35:13 PST
I'm not familiar with the surrounding code, I'm just removing the workaround I put in.

I'd prefer for more ambitious cleanups to be done by other people who have better knowledge of the area.  Does that sound OK?
Comment 8 WebKit Commit Bot 2010-11-29 07:52:04 PST
Comment on attachment 75005 [details]

Clearing flags on attachment: 75005

Committed r72799: <http://trac.webkit.org/changeset/72799>
Comment 9 WebKit Commit Bot 2010-11-29 07:52:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Simon Fraser (smfr) 2010-11-29 08:47:22 PST
I'm confused. Bug 27775 is not fixed. Was Gears changed to avoid this issue?