RESOLVED FIXED 243454
[GLIB] Re-Land 250811@main: Undefined subroutine &Test262::Runner::isWindows 
https://bugs.webkit.org/show_bug.cgi?id=243454
Summary [GLIB] Re-Land 250811@main: Undefined subroutine &Test262::Runner::isWindows
Diego Pino
Reported 2022-08-02 08:20:09 PDT
webkitperl-test is failing in GTK-Linux-64-bit-Release-Tests bot: https://build.webkit.org/#/builders/57/builds/8541/steps/19/logs/stdio ``` Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl ........................... ok Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl .................................. Undefined subroutine &Test262::Runner::isWindows called at /home/buildbot/worker/GTK-Linux-64-bit-Release-Tests/build/Tools/Scripts/test262/Runner.pm line 716. ```
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2022-08-02 08:24:15 PDT
Pull request: https://github.com/webkit/webkit/pull/2949
EWS
Comment 2 2022-08-04 07:18:54 PDT
Committed 253110@main (ecde243930f2): <https://commits.webkit.org/253110@main> Reviewed commits have been landed. Closing PR #2949 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-08-04 07:19:17 PDT
<rdar://problem/98123813>
Robert Jenner
Comment 4 2022-08-04 09:58:35 PDT
Reverted by https://github.com/WebKit/WebKit/pull/3014
Robert Jenner
Comment 5 2022-08-04 10:00:31 PDT
Moving WebKitdirs into a package broke some of our Internal tooling that was rather important. So this has been reverted. Will need to coordinate with you in order to re-land so we can make changes Internally.
EWS
Comment 6 2022-08-04 10:01:00 PDT
Committed 253118@main (aff5e1addc0e): <https://commits.webkit.org/253118@main> Reviewed commits have been landed. Closing PR #3014 and removing active labels.
Robert Jenner
Comment 7 2022-08-04 10:04:21 PDT
We will re-land this patch as soon as we have updated and made the changes needed to our Internal tooling.
Elliott Williams
Comment 8 2022-08-04 13:09:36 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3021
EWS
Comment 9 2022-08-05 16:44:58 PDT
Committed 253165@main (86adbbfd98ab): <https://commits.webkit.org/253165@main> Reviewed commits have been landed. Closing PR #3021 and removing active labels.
Robert Jenner
Comment 10 2022-08-06 11:40:55 PDT
Reverted by https://github.com/WebKit/WebKit/pull/3075
EWS
Comment 11 2022-08-06 11:43:19 PDT
Committed 253181@main (3cc8f9cb8398): <https://commits.webkit.org/253181@main> Reviewed commits have been landed. Closing PR #3075 and removing active labels.
Robert Jenner
Comment 12 2022-08-06 11:50:26 PDT
Had to revert again due to breaking Internal tooling again, but in a different way. Revert was here: https://commits.webkit.org/253181@main
EWS
Comment 13 2022-08-08 17:38:36 PDT
Committed 253243@main (2e6cf95b1034): <https://commits.webkit.org/253243@main> Reviewed commits have been landed. Closing PR #3128 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.