Bug 24345 - wxWebkit should make use of gcc(4 and greater) hidden visibility feature
: wxWebkit should make use of gcc(4 and greater) hidden visibility feature
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: PC Linux
: P2 Enhancement
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-03-04 01:31 PST by
Modified: 2009-05-05 16:12 PST (History)


Attachments
Patch to enable hidden visibility for gcc > 4 (1.70 KB, patch)
2009-03-04 01:32 PST, Malcolm MacLeod
kevino: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-03-04 01:31:38 PST
wxWebKit does not currently make use of the gcc hidden visibility features that are available since gcc 4.
Changing it to make use of these features is trivial as everything is already in place to do so, so the gains that can be had are almost for free.

I have done so and it results in a +-35% binary size decrease (From 30Mib down to 19mib on a 64 bit system). Obviously this also speeds up linking time and other similar benefits.

I will attach the patch to enable this below.
------- Comment #1 From 2009-03-04 01:32:30 PST -------
Created an attachment (id=28259) [details]
Patch to enable hidden visibility for gcc > 4
------- Comment #2 From 2009-03-04 01:34:50 PST -------
Forgot to mention that this has been tested successfully on both an x86 system with GCC 4.1.2 as well as an x86_64 system with GCC 4.3.3
------- Comment #3 From 2009-05-05 16:12:03 PST -------
Landed in r43260, thanks!