Bug 243329 - test-webkitpy is failing to install lupa-1.13.0 on Windows Python
Summary: test-webkitpy is failing to install lupa-1.13.0 on Windows Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-28 18:32 PDT by Fujii Hironori
Modified: 2022-09-28 18:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2022-07-28 21:04 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-07-28 18:32:34 PDT 
webkitpy: Failed to install lupa-1.13.0! on WinCairo buildbot

> ValueError: path '/home/runner/work/lupa/lupa/third-party/lua/lapi.c' cannot be absolute
> Failed to install lupa-1.13.0!

Buildbot: builder WinCairo-64-bit-WKL-Release-Tests build 7512
https://build.webkit.org/#/builders/60/builds/7512
Comment 1 Fujii Hironori 2022-07-28 19:02:58 PDT 
On Windows, "pip install lupa" just downloads a pre-compiled binary.

PS D:\work\tmp> pip install lupa
Collecting lupa
  Downloading lupa-1.13-cp39-cp39-win_amd64.whl (287 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 287.6/287.6 kB 8.9 MB/s eta 0:00:00
Installing collected packages: lupa
Successfully installed lupa-1.13
Comment 2 Fujii Hironori 2022-07-28 19:13:18 PDT 
lupa-1.13/lupa.egg-info/SOURCES.txt of lupa-1.13.tar.gz contains the someone's absolute path.

> ...
> /home/runner/work/lupa/lupa/third-party/lua/lapi.c
> /home/runner/work/lupa/lupa/third-party/lua/lauxlib.c
> /home/runner/work/lupa/lupa/third-party/lua/lbaselib.c
> ...

Unpacking lupa-1.13.tar.gz and invoking "python .\setup.py install" reported the same error.

> ValueError: path '/home/runner/work/lupa/lupa/third-party/lua/lapi.c' cannot be absolute

However, removing the 'lupa.egg-info' directory and invoking "python .\setup.py install" succeeded.
'lupa.egg-info' directory was regenerated and lupa.egg-info/SOURCES.txt contained my absolute path.

> ...
> D:/work/tmp/lupa-1.13/third-party/lua/lapi.c
> D:/work/tmp/lupa-1.13/third-party/lua/lauxlib.c
> D:/work/tmp/lupa-1.13/third-party/lua/lbaselib.c
> ...
Comment 3 Fujii Hironori 2022-07-28 19:37:15 PDT 
244901@main (bug#233734) added the implementation and unit tests of commits.webkit.org.
Comment 4 Fujii Hironori 2022-07-28 21:04:17 PDT 
Created attachment 461288 [details]
Patch
Comment 5 Fujii Hironori 2022-08-01 13:06:16 PDT 
Comment on attachment 461288 [details]
Patch

Thank you.
Comment 6 EWS 2022-08-01 13:42:40 PDT 
Committed 253008@main (5df171bce18e): <https://commits.webkit.org/253008@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461288 [details].
Comment 7 Radar WebKit Bug Importer 2022-08-01 13:45:24 PDT 
<rdar://problem/97933765>