Bug 24329 – REGRESSION: console.dirxml() Console API broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

* SUMMARY
The console.dirxml (from firebug's console API) added in r36255 seems broken in r38297 

* STEPS TO REPRODUCE
Type 'console.dirxml(document.body)' on google.com

Expected: Should return something like https://bugs.webkit.org/attachment.cgi?id=22833

Currently (WebKit r38297 and Safari 4) doesn't print anything in the console. Works great in Firefox.

<rdar://problem/6367127>

[Timothy Hatcher]

Created attachment 28231 [details]
Proposed Patch

[Kevin McCullough]

Comment on attachment 28231 [details]
Proposed Patch


> diff --git a/WebCore/page/Console.cpp b/WebCore/page/Console.cpp
> index 8755f0e..697baac 100644
> --- a/WebCore/page/Console.cpp
> +++ b/WebCore/page/Console.cpp
> @@ -109,12 +109,13 @@ static void printMessageSourceAndLevelPrefix(MessageSource source, MessageLevel
>  
>      const char* levelString;
>      switch (level) {
> +        default:
> +            ASSERT_NOT_REACHED();
> +            levelString = "UNKNOWN";
> +            break;

We usually put the default: at the end of the switch statement

It would be nice if the refactoring was in a separate patch but I don't have many comments and it's good that there is a test case.

[Timothy Hatcher]

Fixed in r41404.