Bug 243284 - [git-webkit] Allow re-running command with --issue
Summary: [git-webkit] Allow re-running command with --issue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-07-27 21:34 PDT by Simon Fraser (smfr)
Modified: 2023-07-20 14:30 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-07-27 21:34:20 PDT 
I did `git webkit pr --no-update --issue 237812`, and it stalled (bug 243283) so I did it again, and got:

LayoutTests % git webkit pr --no-update --issue 237812
Creating a pull-request for '237812' but we're on 'eng/iOS-editingspellingediting-word-with-marker-1-html-causes-the-subsequent-test-to-time-out'

It should be smart enough to know that "eng/iOS-editingspellingediting-word-with-marker-1-html-causes-the-subsequent-test-to-time-out" is associated with the same issue.
Comment 1 Radar WebKit Bug Importer 2022-08-03 21:35:15 PDT 
<rdar://problem/98099682>
Comment 2 serakeri 2022-08-04 13:08:46 PDT 
I'm looking into a fix for this. I think that the issue needs to be pulled from the repository message. Would just comparing the issue number from the head commit work?
Comment 3 Simon Fraser (smfr) 2022-10-11 21:32:29 PDT 
This is probably my biggest issue with the `git webkit` workflow.
Comment 4 Jonathan Bedard 2023-07-07 17:38:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15660
Comment 5 EWS 2023-07-20 14:30:11 PDT 
Committed 266187@main (273f723b9c16): <https://commits.webkit.org/266187@main>

Reviewed commits have been landed. Closing PR #15660 and removing active labels.