Bug 243271 - EWS should not be triggered for multi-year old patches
Summary: EWS should not be triggered for multi-year old patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-27 15:57 PDT by Ryan Haddad
Modified: 2022-07-29 09:18 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-07-27 15:57:10 PDT 
It was pointed out to me on Slack that EWS jobs were triggered for https://bugs.webkit.org/show_bug.cgi?id=127586, which hasn't been modified since 2014.

Not sure if someone triggered this manually or if it a sign of a bug in our infrastructure.

Example: https://ews-build.webkit.org/#/builders/43/builds/15364
Comment 1 Aakash Jain 2022-07-28 04:26:14 PDT 
Logs indicate that Submit to EWS button was pressed on it at 2022-07-27 06:24:07,903 GMT.

It was pressed for both the patches (222545 and 222869) on https://bugs.webkit.org/show_bug.cgi?id=127586

2022-07-27 06:24:07,903 - SubmitToEWS::change: 222545
2022-07-27 06:24:10,702 - SubmitToEWS::change: 222869
Comment 2 Aakash Jain 2022-07-28 04:35:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2807
Comment 3 EWS 2022-07-28 09:57:05 PDT 
Committed 252916@main (6e27809f8901): <https://commits.webkit.org/252916@main>

Reviewed commits have been landed. Closing PR #2807 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-07-28 09:58:16 PDT 
<rdar://problem/97728841>
Comment 5 Aakash Jain 2022-07-29 09:18:05 PDT 
Deployed on the server. Working fine.

e.g: clicking on "Submit for EWS analysis" button on https://ews.webkit.org/status-bubble/300000/ and https://ews.webkit.org/status-bubble/30000000/ now results in immediate error.