Bug 24324 - Make DOMTimer clamp adjustable via settings
Summary: Make DOMTimer clamp adjustable via settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-03 09:43 PST by Mike Belshe
Modified: 2009-03-20 16:56 PDT (History)
0 users

See Also:

Attachments
patch (1.03 KB, patch)
2009-03-03 09:46 PST, Mike Belshe 		hyatt: review-
Details | Formatted Diff | Diff
New patch, using C++ accessors (3.27 KB, patch)
2009-03-05 14:33 PST, Mike Belshe 		hyatt: review-
Details | Formatted Diff | Diff
change m_minTimerInterval to s_minTimerInterval (3.27 KB, patch)
2009-03-12 08:28 PDT, Mike Belshe 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2009-03-03 09:43:10 PST 
Allow the host to control the DOMTimer clamp by making it adjustable in the build.
Comment 1 Mike Belshe 2009-03-03 09:46:26 PST 
Created attachment 28225 [details]
patch
Comment 2 Dave Hyatt 2009-03-05 14:08:11 PST 
Comment on attachment 28225 [details]
patch

I think you need a comment explaining why a #define is being used.  It's ok to mention that Chromium has no clamp in the comment.  We need to make sure people know why this oddity is here, since otherwise they might just yank the code.

Also need a ChangeLog comment.
Comment 3 Mike Belshe 2009-03-05 14:33:55 PST 
Created attachment 28327 [details]
New patch, using C++ accessors
Comment 4 Dave Hyatt 2009-03-11 11:58:08 PDT 
Comment on attachment 28327 [details]
New patch, using C++ accessors

We use "s_" for statics, so this should be s_minTimerInterval.  Other than that, it looks fine.
Comment 5 Mike Belshe 2009-03-12 08:28:56 PDT 
Created attachment 28529 [details]
change m_minTimerInterval to s_minTimerInterval
Comment 6 Dimitri Glazkov (Google) 2009-03-12 09:15:31 PDT 
r=me, given that hyatt already reviewed the substance of the patch.
Comment 7 David Levin 2009-03-20 15:14:50 PDT 
Assign to levin for landing.
Comment 8 David Levin 2009-03-20 15:23:30 PDT 
Please add a link the bug in the ChangeLog in the future.
Comment 9 David Levin 2009-03-20 16:56:15 PDT 
Committed as r41878.