RESOLVED FIXED 24324
Make DOMTimer clamp adjustable via settings 
https://bugs.webkit.org/show_bug.cgi?id=24324
Summary Make DOMTimer clamp adjustable via settings
Mike Belshe
Reported 2009-03-03 09:43:10 PST
Allow the host to control the DOMTimer clamp by making it adjustable in the build.
Attachments
patch (1.03 KB, patch)
2009-03-03 09:46 PST, Mike Belshe 		hyatt: review-
DetailsFormatted DiffDiff
New patch, using C++ accessors (3.27 KB, patch)
2009-03-05 14:33 PST, Mike Belshe 		hyatt: review-
DetailsFormatted DiffDiff
change m_minTimerInterval to s_minTimerInterval (3.27 KB, patch)
2009-03-12 08:28 PDT, Mike Belshe 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike Belshe
Comment 1 2009-03-03 09:46:26 PST
Created attachment 28225 [details] patch
Dave Hyatt
Comment 2 2009-03-05 14:08:11 PST
Comment on attachment 28225 [details] patch I think you need a comment explaining why a #define is being used. It's ok to mention that Chromium has no clamp in the comment. We need to make sure people know why this oddity is here, since otherwise they might just yank the code. Also need a ChangeLog comment.
Mike Belshe
Comment 3 2009-03-05 14:33:55 PST
Created attachment 28327 [details] New patch, using C++ accessors
Dave Hyatt
Comment 4 2009-03-11 11:58:08 PDT
Comment on attachment 28327 [details] New patch, using C++ accessors We use "s_" for statics, so this should be s_minTimerInterval. Other than that, it looks fine.
Mike Belshe
Comment 5 2009-03-12 08:28:56 PDT
Created attachment 28529 [details] change m_minTimerInterval to s_minTimerInterval
Dimitri Glazkov (Google)
Comment 6 2009-03-12 09:15:31 PDT
r=me, given that hyatt already reviewed the substance of the patch.
David Levin
Comment 7 2009-03-20 15:14:50 PDT
Assign to levin for landing.
David Levin
Comment 8 2009-03-20 15:23:30 PDT
Please add a link the bug in the ChangeLog in the future.
David Levin
Comment 9 2009-03-20 16:56:15 PDT
Committed as r41878.
Note You need to log in before you can comment on or make changes to this bug.