WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
243234
Adds "box-sizing: border-box" to table in UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=243234
Summary
Adds "box-sizing: border-box" to table in UA stylesheet
Tim Nguyen (:ntim)
Reported
2022-07-26 16:29:45 PDT
https://wpt.fyi/results/html/rendering/non-replaced-elements/form-controls/resets.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2022-forms
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-07-26 16:30:17 PDT
<
rdar://problem/97634949
>
Karl Dubost
Comment 2
2022-07-26 22:42:07 PDT
Testing Firefox Nightly 105.0a1 Google Chrome Canary 106.0.5203.0 Safari 16.0 18614.1.19.1.5 # Safari
https://github.com/WebKit/WebKit/blob/96a2ba1a024f4616153ea11eeabc148b68820cbf/Source/WebCore/css/html.css#L265-L272
``` td, th { display: table-cell; vertical-align: inherit; } th { font-weight: bold; } ``` and ``` table { display: table; border-collapse: separate; border-spacing: 2px; border-color: gray; text-indent: initial; } ``` # Firefox
https://searchfox.org/mozilla-central/rev/23bf1890e07f780ba70e075bc8f46ffb85d1128c/layout/style/res/html.css#476-481
``` td { display: table-cell; vertical-align: inherit; text-align: unset; padding: 1px; } th { display: table-cell; vertical-align: inherit; font-weight: bold; padding: 1px; text-align: -moz-center-or-inherit; } ``` and ``` table { display: table; border-spacing: 2px; border-collapse: separate; /* XXXldb do we want this if we're border-collapse:collapse ? */ box-sizing: border-box; text-indent: 0; } ``` # Chrome
https://github.com/chromium/chromium/blob/27bbedde58559fefdf22316519176f712e112baa/third_party/blink/renderer/core/html/resources/html.css#L290-L294
``` td, th { display: table-cell; vertical-align: inherit } th { font-weight: bold; text-align: -internal-center } ``` and table ``` table { display: table; border-collapse: separate; border-spacing: 2px; border-color: gray; box-sizing: border-box; text-indent: initial } ``` Let's try to add box-sizing: border-box to table.
Karl Dubost
Comment 3
2022-07-27 07:59:48 PDT
Adding box-sizing: border-box to table { display: table; border-collapse: separate; border-spacing: 2px; border-color: gray; text-indent: initial; } doesn't solve the issue. The test has already an open bug which is
Bug 95123
Karl Dubost
Comment 4
2022-07-27 08:07:18 PDT
Probably to check out for
https://searchfox.org/wubkat/rev/607499977734f77ef66a84a9df7f9b2bf4a03278/Source/WebCore/rendering/RenderTable.cpp#330-365
Karl Dubost
Comment 5
2022-07-27 17:56:01 PDT
Ah wait. No it fixes it I had the wrong build when I tested.
Karl Dubost
Comment 6
2022-07-27 19:41:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2800
Karl Dubost
Comment 7
2022-07-28 06:36:34 PDT
It seems it will fix other tests too.
Tim Nguyen (:ntim)
Comment 8
2022-08-10 17:59:28 PDT
***
Bug 95123
has been marked as a duplicate of this bug. ***
EWS
Comment 9
2022-08-18 21:28:08 PDT
Committed
253581@main
(8915be4c0470): <
https://commits.webkit.org/253581@main
> Reviewed commits have been landed. Closing PR #2800 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug