RESOLVED FIXED 243221
[XCBuild] Legacy build system cleanup 
https://bugs.webkit.org/show_bug.cgi?id=243221
Summary [XCBuild] Legacy build system cleanup
Elliott Williams
Reported 2022-07-26 11:43:03 PDT
There are a number of build settings, script phases, and workarounds which only existed to support the legacy build system. Let's clean them up. For the most part, this can be done by finding usage of WK_WHICH_BUILD_SYSTEM and WK_USE_NEW_BUILD_SYSTEM in xcconfigs and script phases, and deleting the legacy code path.
Attachments
Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2022-07-26 11:45:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2745
Elliott Williams
Comment 2 2022-07-26 11:50:16 PDT
rdar://89701972
Radar WebKit Bug Importer
Comment 3 2022-07-26 11:50:25 PDT
<rdar://problem/97618431>
EWS
Comment 4 2022-07-27 10:32:16 PDT
Committed 252870@main (f5950aef5b7e): <https://commits.webkit.org/252870@main> Reviewed commits have been landed. Closing PR #2745 and removing active labels.
Alex Christensen
Comment 5 2022-07-27 11:54:24 PDT
Reverting in https://bugs.webkit.org/show_bug.cgi?id=243259 because it broke the iOS build make release ARCHS=arm64e SDKROOT=iphoneos.internal
Alex Christensen
Comment 6 2022-07-27 11:55:25 PDT
Reverted by https://github.com/WebKit/WebKit/pull/2787
EWS
Comment 7 2022-07-27 12:53:43 PDT
Committed 252875@main (a790b3beee52): <https://commits.webkit.org/252875@main> Reviewed commits have been landed. Closing PR #2787 and removing active labels.
Elliott Williams
Comment 8 2023-02-22 17:31:55 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/10552
EWS
Comment 9 2023-02-27 12:42:38 PST
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label
EWS
Comment 10 2023-03-02 16:37:02 PST
Committed 261111@main (91b246244bf1): <https://commits.webkit.org/261111@main> Reviewed commits have been landed. Closing PR #10552 and removing active labels.
WebKit Commit Bot
Comment 11 2023-03-03 02:13:02 PST
Re-opened since this is blocked by bug 253301
Alexey Proskuryakov
Comment 12 2023-03-05 11:31:12 PST
rdar://89701972
Elliott Williams
Comment 13 2023-03-27 09:18:43 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12010
EWS
Comment 14 2023-03-27 11:10:43 PDT
Committed 262162@main (ecef01756ff9): <https://commits.webkit.org/262162@main> Reviewed commits have been landed. Closing PR #12010 and removing active labels.
Elliott Williams
Comment 15 2023-03-29 12:08:16 PDT
Reopening to fix some additional places where these variables are used.
Elliott Williams
Comment 16 2023-03-29 12:19:20 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12125
EWS
Comment 17 2023-03-29 13:30:03 PDT
Committed 262287@main (dbd94e530aea): <https://commits.webkit.org/262287@main> Reviewed commits have been landed. Closing PR #12125 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.