Currently a timeout.
<rdar://problem/97601722>
Created attachment 461221 [details] Patch
Comment on attachment 461221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461221&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2373 > if (!renderer() || !is<Element>(node())) We don’t need this renderer check here anymore
(In reply to chris fleizach from comment #3) > Comment on attachment 461221 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461221&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2373 > > if (!renderer() || !is<Element>(node())) > > We don’t need this renderer check here anymore Down below we do: auto& editor = renderer()->frame().editor(); So early return if !renderer() is appropriate.
(In reply to Andres Gonzalez from comment #4) > (In reply to chris fleizach from comment #3) > > Comment on attachment 461221 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=461221&action=review > > > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2373 > > > if (!renderer() || !is<Element>(node())) > > > > We don’t need this renderer check here anymore > > Down below we do: > > auto& editor = renderer()->frame().editor(); > > So early return if !renderer() is appropriate. This is the RenderObject implementation for frame: inline Frame& RenderObject::frame() const { return *document().frame(); } Is it possible to use the node to do something similar, making this function not require a renderer at all? This could improve our display:contents support. Up to you if you would prefer not to address that now though.
Committed 252863@main (f410828332d2): <https://commits.webkit.org/252863@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461221 [details].