Bug 24321 – Add V8 bindings headers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Dimitri Glazkov (Google)]

These are temporary forwarding headers, which I intended to only keep downstream until fully baked, but with others picking up upstreaming work, it's better to have them upstream, too -- to avoid the confusion.

[Dimitri Glazkov (Google)]

Created attachment 28223 [details]
Add V8 bindings headers

 WebCore/ChangeLog                                  |   22 ++++++
 WebCore/bindings/v8/V8Binding.h                    |   75 +++++++++++++++++++
 WebCore/bindings/v8/V8Proxy.h                      |   79 ++++++++++++++++++++
 WebCore/bindings/v8/custom/V8CustomBinding.h       |   38 ++++++++++
 WebCore/bindings/v8/custom/V8CustomEventListener.h |   38 ++++++++++
 5 files changed, 252 insertions(+), 0 deletions(-)

[Darin Fisher (:fishd, Google)]

Comment on attachment 28223 [details]
Add V8 bindings headers

>+++ b/WebCore/ChangeLog
...
>+        * bindings/v8/V8Binding.h: Added.
>+        (WebCore::toInt32):
>+        (WebCore::toFloat):
>+        (WebCore::toWebCoreString):
>+        (WebCore::toWebCoreStringWithNullCheck):
>+        (WebCore::isUndefinedOrNull):
>+        (WebCore::v8Boolean):
>+        * bindings/v8/V8Proxy.h: Added.
>+        (WebCore::notHandledByInterceptor):
>+        (WebCore::deletionNotHandledByInterceptor):
>+        (WebCore::throwError):
>+        (WebCore::toV8):
>+        * bindings/v8/custom/V8CustomBinding.h: Added.
>+        * bindings/v8/custom/V8CustomEventListener.h: Added.

nit: remove the functions listed by prepare-ChangeLog for newly
added files.


>+++ b/WebCore/bindings/v8/V8Binding.h
...
>+        // FIXME: Rename valueToStringWithNullCheck once migration is complete
>+    inline String toWebCoreStringWithNullCheck(v8::Handle<v8::Value> value)

nit: indentation


OK, LGTM

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/41394.