Bug 24321 - Add V8 bindings headers
Summary: Add V8 bindings headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-03 09:04 PST by Dimitri Glazkov (Google)
Modified: 2009-03-03 10:38 PST (History)
0 users

See Also:


Attachments
Add V8 bindings headers (11.10 KB, patch)
2009-03-03 09:05 PST, Dimitri Glazkov (Google)
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-03-03 09:04:26 PST
These are temporary forwarding headers, which I intended to only keep downstream until fully baked, but with others picking up upstreaming work, it's better to have them upstream, too -- to avoid the confusion.
Comment 1 Dimitri Glazkov (Google) 2009-03-03 09:05:36 PST
Created attachment 28223 [details]
Add V8 bindings headers

 WebCore/ChangeLog                                  |   22 ++++++
 WebCore/bindings/v8/V8Binding.h                    |   75 +++++++++++++++++++
 WebCore/bindings/v8/V8Proxy.h                      |   79 ++++++++++++++++++++
 WebCore/bindings/v8/custom/V8CustomBinding.h       |   38 ++++++++++
 WebCore/bindings/v8/custom/V8CustomEventListener.h |   38 ++++++++++
 5 files changed, 252 insertions(+), 0 deletions(-)
Comment 2 Darin Fisher (:fishd, Google) 2009-03-03 09:57:04 PST
Comment on attachment 28223 [details]
Add V8 bindings headers

>+++ b/WebCore/ChangeLog
...
>+        * bindings/v8/V8Binding.h: Added.
>+        (WebCore::toInt32):
>+        (WebCore::toFloat):
>+        (WebCore::toWebCoreString):
>+        (WebCore::toWebCoreStringWithNullCheck):
>+        (WebCore::isUndefinedOrNull):
>+        (WebCore::v8Boolean):
>+        * bindings/v8/V8Proxy.h: Added.
>+        (WebCore::notHandledByInterceptor):
>+        (WebCore::deletionNotHandledByInterceptor):
>+        (WebCore::throwError):
>+        (WebCore::toV8):
>+        * bindings/v8/custom/V8CustomBinding.h: Added.
>+        * bindings/v8/custom/V8CustomEventListener.h: Added.

nit: remove the functions listed by prepare-ChangeLog for newly
added files.


>+++ b/WebCore/bindings/v8/V8Binding.h
...
>+        // FIXME: Rename valueToStringWithNullCheck once migration is complete
>+    inline String toWebCoreStringWithNullCheck(v8::Handle<v8::Value> value)

nit: indentation


OK, LGTM
Comment 3 Dimitri Glazkov (Google) 2009-03-03 10:38:44 PST
Landed as http://trac.webkit.org/changeset/41394.