Bug 243204 – ImageDocument should support dark mode

• Status: NEW
• Component: Images

[Pascal Abresch]

Currently images will open with a white frame in epiphany and ios Safari.

Adding color-scheme: light dark; to the document should fix this.

similar to https://bugs.webkit.org/show_bug.cgi?id=242950

[Pascal Abresch]

https://github.com/WebKit/WebKit/pull/2734

[Pascal Abresch]

Created attachment 461339 [details]
Patch

[Darin Adler]

Comment on attachment 461339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461339&action=review

Thanks, I think this is a good idea.

> LayoutTests/fast/loader/image-document-dark-mode.html:5
> +<iframe src="resources/[e-mail]">

Can we instead construct a test that uses a dark mode document with an image element in it in the expected.html? The reason I suggest this is that an expected.html test is even more useful than a mismatch.html for catching future mistakes. And also, a test structured in that way could probably be turned on everywhere; it would automatically do the right thing on platforms with no dark mode support. The only tricky thing about such a test might be matching the layout that you’d get with an iframe that directly references an image, but I think that’s something likely to stay stable for a long time.

[Darin Adler]

I wish we had done that for bug 242950 too.

I wouldn’t block landing this for that test change, but I think we should improve these tests.

[Radar WebKit Bug Importer]

<rdar://problem/97965029>

[Pascal Abresch]

I can work on improving the test next week.