Bug 243197 - [LFC][IFC] Inconsistent integral rounding of baseline relative logical top values
Summary: [LFC][IFC] Inconsistent integral rounding of baseline relative logical top va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-25 21:47 PDT by zalan
Modified: 2022-08-15 09:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2022-07-25 22:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.43 KB, patch)
2022-07-26 06:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.41 KB, patch)
2022-07-26 08:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-07-25 21:47:57 PDT 
ssia
Comment 1 zalan 2022-07-25 22:14:37 PDT 
Created attachment 461212 [details]
Patch
Comment 2 zalan 2022-07-26 06:12:17 PDT 
Created attachment 461222 [details]
Patch
Comment 3 Antti Koivisto 2022-07-26 06:30:51 PDT 
Comment on attachment 461222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461222&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:127
> +    void setLogicalTop(InlineLayoutUnit logicalTop) { logicalTop >= 0 ? m_logicalRect.setTop(roundToInt(logicalTop)) : m_logicalRect.setTop(-roundToInt(-logicalTop)); }

I think you want ?: inside setTop
Comment 4 zalan 2022-07-26 06:36:20 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 461222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461222&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:127
> > +    void setLogicalTop(InlineLayoutUnit logicalTop) { logicalTop >= 0 ? m_logicalRect.setTop(roundToInt(logicalTop)) : m_logicalRect.setTop(-roundToInt(-logicalTop)); }
> 
> I think you want ?: inside setTop
oops, right.
Comment 5 zalan 2022-07-26 08:02:54 PDT 
Created attachment 461223 [details]
Patch
Comment 6 EWS 2022-07-26 09:13:47 PDT 
Committed 252825@main (c4803567c7f8): <https://commits.webkit.org/252825@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461223 [details].
Comment 7 Radar WebKit Bug Importer 2022-07-26 09:14:34 PDT 
<rdar://problem/97609624>