Bug 243186 - AX: ApplicationAccessibilityEnabled pref value is not synced from the UI process to web content process upon initialization
Summary: AX: ApplicationAccessibilityEnabled pref value is not synced from the UI proc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-25 17:24 PDT by Tyler Wilcock
Modified: 2022-07-26 11:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.38 KB, patch)
2022-07-25 17:33 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (5.59 KB, patch)
2022-07-25 19:07 PDT, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-07-25 17:24:28 PDT
When initializing a new web process, the UI process should copy over the value of these prefs so web content has the correct state for them.
Comment 1 Radar WebKit Bug Importer 2022-07-25 17:24:39 PDT
<rdar://problem/97577824>
Comment 2 Tyler Wilcock 2022-07-25 17:30:41 PDT
rdar://97334840
Comment 3 Tyler Wilcock 2022-07-25 17:33:44 PDT
Created attachment 461207 [details]
Patch
Comment 4 chris fleizach 2022-07-25 17:42:00 PDT
Comment on attachment 461207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461207&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1050
> +    if (preferences.accessibilityEnabled)

It seems like we might want to also set if it’s off
As in if the pref is written and then loaded the next time
Comment 5 Tyler Wilcock 2022-07-25 19:07:44 PDT
Created attachment 461210 [details]
Patch
Comment 6 EWS 2022-07-26 11:32:03 PDT
Committed 252837@main (b315e3a4cf18): <https://commits.webkit.org/252837@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461210 [details].