Bug 243161 - [GraphicsContextGLTextureMapperANGLE][WebGL2] webgl/2.0.y/deqp/functional/gles3/rbostatequery.html is failing
Summary: [GraphicsContextGLTextureMapperANGLE][WebGL2] webgl/2.0.y/deqp/functional/gle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-24 18:28 PDT by Fujii Hironori
Modified: 2022-07-26 17:25 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2022-07-24 18:35 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2022-07-25 17:54 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-07-24 18:28:25 PDT
[GraphicsContextGLTextureMapperANGLE][WebGL2] webgl/2.0.y/deqp/functional/gles3/rbostatequery.html is failing

GL_ANGLE_framebuffer_multisample extension is needed.

See also:
 Bug 229950 – webgl/2.0.y/deqp/functional/gles3/rbostatequery.html fails on Metal
Comment 1 Fujii Hironori 2022-07-24 18:35:00 PDT
Created attachment 461184 [details]
Patch
Comment 2 Fujii Hironori 2022-07-25 17:54:47 PDT
Created attachment 461208 [details]
Patch
Comment 3 Kenneth Russell 2022-07-26 15:46:28 PDT
Comment on attachment 461208 [details]
Patch

Again I'm surprised that enabling this extension was necessary. The functionality has been folded into the core ES 3.0 API. Perhaps the issue is that the surrounding code in WebKit is calling in through the extension entry points, and because this is a WebGL-compatible context, all extensions must be enabled manually. Regardless, r+.
Comment 4 Fujii Hironori 2022-07-26 16:46:28 PDT
Comment on attachment 461208 [details]
Patch

Thank you for the review.
Comment 5 EWS 2022-07-26 17:24:52 PDT
Committed 252851@main (1a225b0ac8f1): <https://commits.webkit.org/252851@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461208 [details].
Comment 6 Radar WebKit Bug Importer 2022-07-26 17:25:33 PDT
<rdar://problem/97637090>