Bug 243156 - git-webkit setup should not override existing user information
Summary: git-webkit setup should not override existing user information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-07-24 14:51 PDT by Yusuke Suzuki
Modified: 2022-08-29 16:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-07-24 14:51:04 PDT 
I'm using personal email for global git [user] configuration, and setting Apple specific email in WebKit tree under `.git/config`.
But every time I ran `git-webkit setup`, this configuration is cleared and altered with the global one.
If we already have a [user] configuration in `.git/config`, then `git-webkit setup` should not override it.
Comment 1 Radar WebKit Bug Importer 2022-07-31 14:52:15 PDT 
<rdar://problem/97879666>
Comment 2 serakeri 2022-08-02 14:01:49 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2962
Comment 3 EWS 2022-08-18 15:23:30 PDT 
Committed 253573@main (b92d2c69a13c): <https://commits.webkit.org/253573@main>

Reviewed commits have been landed. Closing PR #2962 and removing active labels.
Comment 4 EWS 2022-08-29 16:12:26 PDT 
Committed 252432.271@safari-7614-branch (5cdf5774c544): <https://commits.webkit.org/252432.271@safari-7614-branch>

Reviewed commits have been landed. Closing PR #35 and removing active labels.