Bug 24315 – WMLInputElement.cpp produces build-time error

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

Writing of function below has error.

void WMLInputElement::defaultEventHandler(Event* evt)
{
..............
        RenderObject* r = renderer();
        if (r /*&& r->isEdited()*//*JJH*/) {
            dispatchEventForType(eventNames().changeEvent, true, false);
            
            // Refetch the renderer since arbitrary JS code run during onchange can do anything, including destroying it.
            r = renderer();
        //    if (r)					/*JJH*/
        //        r->setEdited(false);	/*JJH*/
        }
..............
}

note blockings of code above commented with JJH.

Class RenderObject doesn't include function, isEdited(), setEdited()

To test WML page I only had to block out errornous code above.

I am testing with nightly build WebKit-r41348.

[Mark Rowe (bdash)]

*** Bug 24316 has been marked as a duplicate of this bug. ***

[Mark Rowe (bdash)]

This is probably a result of <http://trac.webkit.org/changeset/40983>.  That changeset should also make the fix for this WML failure relatively obvious if you'd care to contribute a patch.

[Sam Black]

Created attachment 29112 [details]
Fix build errors with WMLInputElement.cpp

Fixes build errors with WMLInputElement.cpp, using commit #40983 as a basis.

Tested using WebKit r42075 on GNU/Linux (GCC 4.2.4, glibc 2.7, GTK+2 2.14.6)

[Darin Adler]

Comment on attachment 29112 [details]
Fix build errors with WMLInputElement.cpp

Casts should use the new checked cast toRenderTextControl, not a direct static_cast.

It's not clear why you're calling isTextField in one case and not the other. It's not needed in either case since this class always creates a renderer derived from RenderTextControl.

[Sam Black]

I based the patch on the edits to trunk/WebCore/html/HTMLInputElement.cpp made in changeset #40983 as directed in comment #2.

[George Staikos]

Not a valid bug anymore.