Bug 24311 - Make IDL returning DOMObject use [V8Custom]
Summary: Make IDL returning DOMObject use [V8Custom]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mike Belshe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 19:09 PST by Mike Belshe
Modified: 2009-03-03 08:07 PST (History)
1 user (show)

See Also:

Attachments
patch (1.39 KB, patch)
2009-03-02 19:13 PST, Mike Belshe 		fishd: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2009-03-02 19:09:01 PST 
The v8 implementation needs these to be custom since it can't know the type to convert to between DOMObject and CanvasRenderingContext2D.

Files impacted:
   HTMLCanvasElement.idl
   Document.idl
Comment 1 Mike Belshe 2009-03-02 19:13:44 PST 
Created attachment 28211 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2009-03-02 20:03:45 PST 
Comment on attachment 28211 [details]
patch

OK, LGTM

I'll take care of closing out bug 23809 in favor of this one.  Thanks!
Comment 3 Darin Fisher (:fishd, Google) 2009-03-03 08:07:14 PST 
Landed as http://trac.webkit.org/changeset/41380