RESOLVED WONTFIX24309
Unify JSC/V8 HTMLDocument.idl 
https://bugs.webkit.org/show_bug.cgi?id=24309
Summary Unify JSC/V8 HTMLDocument.idl
Mike Belshe
Reported 2009-03-02 17:32:53 PST
Handling of document.all is special in the JS engines. V8 marks this as readonly and not-custom; JSC marks it as custom and deletable.
Attachments
patch (988 bytes, patch)
2009-03-02 17:55 PST, Mike Belshe 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Belshe
Comment 1 2009-03-02 17:55:36 PST
Created attachment 28210 [details] patch
Sam Weinig
Comment 2 2009-03-02 18:38:52 PST
Does this imply that the v8 bindings have a different behavior than the JSC ones for document.all?
Darin Fisher (:fishd, Google)
Comment 3 2009-03-02 20:16:22 PST
No, it behaves the same. We use a different mechanism to implement the undetectable behavior for document.all. Search for DocAll in this file: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/v8_proxy.cpp?view=markup
Mike Belshe
Comment 4 2009-03-03 08:06:22 PST
@Sam: Yes, both V8 and JSC pass the same tests and implement the same behavior. It's just the way that the bindings are generated that is different. In this case, V8 uses no special ("custom") binding, and marks the property read only. JSC's bindings are generated through a custom handler.
Eric Seidel (no email)
Comment 5 2009-03-11 00:10:05 PDT
Comment on attachment 28210 [details] patch I would prefer if Sam reviewed this.
Mike Belshe
Comment 6 2009-03-12 15:44:25 PDT
In reworking some of this, I decided not to make this change. There is a better way.
David Levin
Comment 7 2009-03-26 11:21:27 PDT
Comment on attachment 28210 [details] patch Marked obsolete and removed ?: Per Mike's comment "I decided not to make this change." to remove the from the review queue.
Note You need to log in before you can comment on or make changes to this bug.