Bug 24307 - m_highlightedNode should be cleared on hideHighlight
Summary: m_highlightedNode should be cleared on hideHighlight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 16:50 PST by Ojan Vafai
Modified: 2009-03-02 18:13 PST (History)
0 users

See Also:


Attachments
Null m_highlightedNode on hideHighlight() (1.01 KB, patch)
2009-03-02 17:34 PST, Ojan Vafai
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2009-03-02 16:50:46 PST
This makes it consistent with setting it on highlight(). More importantly, the chromium build relies on the null-check at the beginning of drawNodeHighlight as to whether to draw the node highlight.
Comment 1 Ojan Vafai 2009-03-02 17:34:54 PST
Created attachment 28208 [details]
Null m_highlightedNode on hideHighlight()

 WebCore/ChangeLog                         |   11 +++++++++++
 WebCore/inspector/InspectorController.cpp |    1 +
 2 files changed, 12 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-03-02 18:13:02 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
Committed r41377