WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24307
m_highlightedNode should be cleared on hideHighlight
https://bugs.webkit.org/show_bug.cgi?id=24307
Summary
m_highlightedNode should be cleared on hideHighlight
Ojan Vafai
Reported
2009-03-02 16:50:46 PST
This makes it consistent with setting it on highlight(). More importantly, the chromium build relies on the null-check at the beginning of drawNodeHighlight as to whether to draw the node highlight.
Attachments
Null m_highlightedNode on hideHighlight()
(1.01 KB, patch)
2009-03-02 17:34 PST
,
Ojan Vafai
adele
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2009-03-02 17:34:54 PST
Created
attachment 28208
[details]
Null m_highlightedNode on hideHighlight() WebCore/ChangeLog | 11 +++++++++++ WebCore/inspector/InspectorController.cpp | 1 + 2 files changed, 12 insertions(+), 0 deletions(-)
Eric Seidel (no email)
Comment 2
2009-03-02 18:13:02 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp Committed
r41377
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug