Bug 24297 - Purify UMRs in TransparencyWin for Chromium
Summary: Purify UMRs in TransparencyWin for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Brett Wilson (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 11:05 PST by Brett Wilson (Google)
Modified: 2009-04-09 12:45 PDT (History)
0 users

See Also:


Attachments
Patch (1.65 KB, patch)
2009-03-02 11:15 PST, Brett Wilson (Google)
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2009-03-02 11:05:55 PST
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=8219

Uninitialized memory read in 
WebCore::TransparencyWin::compositeOpaqueComposite(void)
Error Location
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:3
90  WebCore::TransparencyWin::compositeOpaqueComposite(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1
69  WebCore::TransparencyWin::~TransparencyWin(void)
   webkit/tools/webcore_unit_tests/transparencywin_unittest.cpp:239  
WebCore::TransparencyWin_OpaqueCompositeLayer_Test::TestBody(void)
   testing/gtest/src/gtest.cc:2010  testing::Test::Run(void)
   ^^^
Alloc Location
   ...
   skia/corecg/skmemory_stdlib.cpp:260  sk_malloc_flags(UINT,UINT)
   skia/sgl/skbitmap.cpp:412  
SkBitmap::HeapAllocator::allocPixelRef(SkBitmap *,SkColorTable *)
   skia/sgl/skbitmap.cpp:311  SkBitmap::allocPixels(Allocator::SkBitmap 
*,SkColorTable *)
   skia/include/skbitmap.h:210  SkBitmap::allocPixels(SkColorTable *)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1
16  WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers(IntSize::WebCore 
const&,bool)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:3
63  WebCore::TransparencyWin::initializeNewContext(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:2
34  WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:2
16  WebCore::TransparencyWin::setupLayer(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1
88  WebCore::TransparencyWin::init(GraphicsContext::WebCore 
*,LayerMode::TransparencyWin::WebCore,TransformMode::TransparencyWin::WebCo
re,IntRect::WebCore const&)
   webkit/tools/webcore_unit_tests/transparencywin_unittest.cpp:234  
WebCore::TransparencyWin_OpaqueCompositeLayer_Test::TestBody(void)
   testing/gtest/src/gtest.cc:2010  testing::Test::Run(void)
Comment 1 Brett Wilson (Google) 2009-03-02 11:15:25 PST
Created attachment 28187 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-03-02 11:32:10 PST
Comment on attachment 28187 [details]
Patch

LGTM, but this file is misnamed.  It should be named TransparencyChromiumWin.cpp.
Comment 3 Darin Fisher (:fishd, Google) 2009-03-02 11:32:45 PST
also, please be sure to add a bug link in the ChangeLog before committing.