Bug 24297 – Purify UMRs in TransparencyWin for Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Brett Wilson (Google)]

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=8219

Uninitialized memory read in 
WebCore::TransparencyWin::compositeOpaqueComposite(void)
Error Location
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:3
90  WebCore::TransparencyWin::compositeOpaqueComposite(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1
69  WebCore::TransparencyWin::~TransparencyWin(void)
   webkit/tools/webcore_unit_tests/transparencywin_unittest.cpp:239  
WebCore::TransparencyWin_OpaqueCompositeLayer_Test::TestBody(void)
   testing/gtest/src/gtest.cc:2010  testing::Test::Run(void)
   ^^^
Alloc Location
   ...
   skia/corecg/skmemory_stdlib.cpp:260  sk_malloc_flags(UINT,UINT)
   skia/sgl/skbitmap.cpp:412  
SkBitmap::HeapAllocator::allocPixelRef(SkBitmap *,SkColorTable *)
   skia/sgl/skbitmap.cpp:311  SkBitmap::allocPixels(Allocator::SkBitmap 
*,SkColorTable *)
   skia/include/skbitmap.h:210  SkBitmap::allocPixels(SkColorTable *)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1
16  WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers(IntSize::WebCore 
const&,bool)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:3
63  WebCore::TransparencyWin::initializeNewContext(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:2
34  WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:2
16  WebCore::TransparencyWin::setupLayer(void)
   
third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1
88  WebCore::TransparencyWin::init(GraphicsContext::WebCore 
*,LayerMode::TransparencyWin::WebCore,TransformMode::TransparencyWin::WebCo
re,IntRect::WebCore const&)
   webkit/tools/webcore_unit_tests/transparencywin_unittest.cpp:234  
WebCore::TransparencyWin_OpaqueCompositeLayer_Test::TestBody(void)
   testing/gtest/src/gtest.cc:2010  testing::Test::Run(void)

[Brett Wilson (Google)]

Created attachment 28187 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 28187 [details]
Patch

LGTM, but this file is misnamed.  It should be named TransparencyChromiumWin.cpp.

[Darin Fisher (:fishd, Google)]

also, please be sure to add a bug link in the ChangeLog before committing.