Bug 24292 - Enable drt api for animations in qt port
Summary: Enable drt api for animations in qt port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 09:46 PST by Adam Treat
Modified: 2009-03-02 13:01 PST (History)
0 users

See Also:


Attachments
Implement DRT api for animations (6.38 KB, patch)
2009-03-02 09:47 PST, Adam Treat
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2009-03-02 09:46:37 PST
Hi,

Currently, the Qt port version of DRT lacks the necessary API to allow the animation tests to pass.  The attached patch fixes this and now all animation tests pass.
Comment 1 Adam Treat 2009-03-02 09:47:52 PST
Created attachment 28180 [details]
Implement DRT api for animations
Comment 2 Eric Seidel (no email) 2009-03-02 10:11:49 PST
Comment on attachment 28180 [details]
Implement DRT api for animations

Some style issues discussed over IRC, which you can fix when landing.  Also, "name" needs a better argument name, probably "propertyName".  I don't need to see this again, glad to see this support added!
Comment 3 Adam Treat 2009-03-02 10:29:25 PST
Landed with r41361.