Bug 242873 - [ews-build.webkit.org] Check ownership of target branch
Summary: [ews-build.webkit.org] Check ownership of target branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-18 16:03 PDT by Jonathan Bedard
Modified: 2022-07-19 13:47 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-07-18 16:03:36 PDT 
If the branch a PR is targeting is owned by a different remote than the PR was made against, we shouldn't let merge-queue land the change. This is most relevant for branches that are actually owned by origin and remotes that may be non-public, as pushing to an origin-owned branch would either break syncing or publish changes that may be intended to remain hidden.
Comment 1 Radar WebKit Bug Importer 2022-07-18 16:03:53 PDT 
<rdar://problem/97225367>
Comment 2 Jonathan Bedard 2022-07-18 16:14:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2528
Comment 3 Jonathan Bedard 2022-07-18 16:31:37 PDT 
Pull request: https://github.com/apple/WebKit/pull/16
Comment 4 EWS 2022-07-18 17:22:47 PDT 
Committed 252584@main (038c4c107f86): <https://commits.webkit.org/252584@main>

Reviewed commits have been landed. Closing PR #2528 and removing active labels.
Comment 5 Jonathan Bedard 2022-07-19 13:24:13 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/2561
Comment 6 EWS 2022-07-19 13:47:08 PDT 
Committed 252614@main (59ee02e5c6f4): <https://commits.webkit.org/252614@main>

Reviewed commits have been landed. Closing PR #2561 and removing active labels.