Bug 242842 - There should be a way to indicate that PR should not close a bug
Summary: There should be a way to indicate that PR should not close a bug
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency treegraph
 
Reported: 2022-07-16 21:32 PDT by Ryosuke Niwa
Modified: 2022-07-23 21:33 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-07-16 21:32:42 PDT
When landing test expectation changes, etc... in GitHub, there should be a label to indicate that
merge-queue / unsafe-merge-queue should not close the Bugzilla bug.
Comment 1 Alexey Proskuryakov 2022-07-18 17:51:44 PDT
I think that such mechanism exists and is used by bot watchers, but I don't know what it is.
Comment 2 Fujii Hironori 2022-07-18 21:11:28 PDT
See Bug#239604
Comment 3 Ryosuke Niwa 2022-07-18 21:30:02 PDT
lol, it looks for the substring "Unreviewed test gardening":
https://github.com/WebKit/WebKit/commit/253a62f8ead480bd1f0683cace622b2ebc1231cd
Comment 4 Alexey Proskuryakov 2022-07-19 09:23:16 PDT
Is this just a dupe of bug 239604 at this point, or are you looking for a different solution?
Comment 5 Ryosuke Niwa 2022-07-19 11:23:30 PDT
(In reply to Alexey Proskuryakov from comment #4)
> Is this just a dupe of bug 239604 at this point, or are you looking for a
> different solution?

I don't think special casing test gardening makes sense. We need the equivalent of --no-close for git-webkit.
Comment 6 Radar WebKit Bug Importer 2022-07-23 21:33:16 PDT
<rdar://problem/97502232>