WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
242841
GitHub shows reviewer name more prominently than patch author
https://bugs.webkit.org/show_bug.cgi?id=242841
Summary
GitHub shows reviewer name more prominently than patch author
Ryosuke Niwa
Reported
2022-07-16 21:30:23 PDT
The way GitHub presents commit messages, the name of reviewer will end up prominently presented as opposed to the actual patch author.
Attachments
Add attachment
proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1
2022-07-16 21:49:03 PDT
The Github UI shows certain commit metadata specially, like the committer and authors, just below the commit message, but I don't know if anything else (including any structured git commit message trailer, like a "Signed-Off-By:" line) gets shown specially. Without asking Github to make changes to their UI, the only options I can think of would be: 1. Move the "Reviewed by" line to the end of the commit message, so that it's closer to the author's username in the Github UI. 2. Add the author details into the commit message too. The reviewer information is pretty important, and I like where it is in the commit message (towards the top). Adding the author name to the commit message duplicates information from the git commit metadata, and duplicates the information shown when looking at the commit in other tools (like `git log`).
Ryosuke Niwa
Comment 2
2022-07-16 21:50:15 PDT
We might want to add the author name at the top even though it's somewhat redundant with Git meta data. The old change log contained author & authoring date as the first line.
Alexey Proskuryakov
Comment 3
2022-07-17 16:58:19 PDT
It’s also equally hard to find the date.
Radar WebKit Bug Importer
Comment 4
2022-07-23 21:31:14 PDT
<
rdar://problem/97502194
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug