Bug 24284 - Qt build environment simplifying
Summary: Qt build environment simplifying
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 02:11 PST by Csaba Osztrogonác
Modified: 2009-05-11 10:58 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (5.23 KB, patch)
2009-03-02 02:34 PST, Csaba Osztrogonác
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2009-03-02 02:11:43 PST
In Qt build environment (pri and pro) files there are several duplicated values. I would like to remove them in the interest of clear and simplify code.
Comment 1 Csaba Osztrogonác 2009-03-02 02:34:00 PST
Created attachment 28159 [details]
proposed patch

jsc.pro
--------
Also defined in JavaScriptCore.pri: (bindings and bindings/c are not exists)
-INCLUDEPATH += $$PWD \
-    $$PWD/parser \
-    $$PWD/bindings \
-    $$PWD/bindings/c \
-    $$PWD/wtf \
-    $$PWD/jit \
-    $$PWD/bytecode


Also defined in WebKit.pri:
-DEFINES += BUILDING_QT__ 
-CONFIG(release) {
-    DEFINES += NDEBUG USE_SYSTEM_MALLOC
-}


WebCore.pro
------------
Also defined in JavaScriptCore.pri:
-INCLUDEPATH += $$PWD $$PWD/../JavaScriptCore $$PWD/../JavaScriptCore/ForwardingHeaders \
-               $$PWD/../JavaScriptCore/interpreter \
-               $$PWD/../JavaScriptCore/bytecode \
-               $$PWD/../JavaScriptCore/debugger \
-               $$PWD/../JavaScriptCore/parser \
-               $$PWD/../JavaScriptCore/runtime \
-               $$PWD/../JavaScriptCore/bindings \
-               $$PWD/../JavaScriptCore/wrec \
-               $$PWD/../JavaScriptCore/jit \
-               $$PWD/../JavaScriptCore/wtf \ 

Also defined in WebCore.pro:
-    $$PWD/loader \
-    $$PWD/bridge/qt
-                $$PWD/bridge \
Comment 2 Holger Freyther 2009-05-11 03:46:21 PDT
Comment on attachment 28159 [details]
proposed patch

Looks like a nice cleanup.
Comment 3 Holger Freyther 2009-05-11 09:23:03 PDT
Please remove the WARNING NO... from the ChangeLog in the future. Landed in r43494.
Comment 4 Csaba Osztrogonác 2009-05-11 10:58:44 PDT
(In reply to comment #3)
> Please remove the WARNING NO... from the ChangeLog in the future. Landed in
> r43494.

OK, I'll do it next time. Thanks.