Bug 24284 – Qt build environment simplifying

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Csaba Osztrogonác]

In Qt build environment (pri and pro) files there are several duplicated values. I would like to remove them in the interest of clear and simplify code.

[Csaba Osztrogonác]

Created attachment 28159 [details]
proposed patch

jsc.pro
--------
Also defined in JavaScriptCore.pri: (bindings and bindings/c are not exists)
-INCLUDEPATH += $$PWD \
-    $$PWD/parser \
-    $$PWD/bindings \
-    $$PWD/bindings/c \
-    $$PWD/wtf \
-    $$PWD/jit \
-    $$PWD/bytecode


Also defined in WebKit.pri:
-DEFINES += BUILDING_QT__ 
-CONFIG(release) {
-    DEFINES += NDEBUG USE_SYSTEM_MALLOC
-}


WebCore.pro
------------
Also defined in JavaScriptCore.pri:
-INCLUDEPATH += $$PWD $$PWD/../JavaScriptCore $$PWD/../JavaScriptCore/ForwardingHeaders \
-               $$PWD/../JavaScriptCore/interpreter \
-               $$PWD/../JavaScriptCore/bytecode \
-               $$PWD/../JavaScriptCore/debugger \
-               $$PWD/../JavaScriptCore/parser \
-               $$PWD/../JavaScriptCore/runtime \
-               $$PWD/../JavaScriptCore/bindings \
-               $$PWD/../JavaScriptCore/wrec \
-               $$PWD/../JavaScriptCore/jit \
-               $$PWD/../JavaScriptCore/wtf \ 

Also defined in WebCore.pro:
-    $$PWD/loader \
-    $$PWD/bridge/qt
-                $$PWD/bridge \

[Holger Freyther]

Comment on attachment 28159 [details]
proposed patch

Looks like a nice cleanup.

[Holger Freyther]

Please remove the WARNING NO... from the ChangeLog in the future. Landed in r43494.

[Csaba Osztrogonác]

(In reply to comment #3)
> Please remove the WARNING NO... from the ChangeLog in the future. Landed in
> r43494.

OK, I'll do it next time. Thanks.