Bug 242783 - Validate array sizes in WebGLRenderingContextBase::initializeNewContext
Summary: Validate array sizes in WebGLRenderingContextBase::initializeNewContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-14 19:01 PDT by Dan Glastonbury
Modified: 2022-07-14 20:34 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-07-14 19:01:13 PDT 
Some arrays have minimum sizes specified by the OpenGL ES spec and should never be zero. GL_COMBINED_TEXTURE_IMAGE_UNITS and GL_MAX_VERTEX_ATTRIBS have minimum values and should never be 0. When initialising a new context, if these values are 0 that indicates a problem with the GL context. The context is marked as lost to stop further commands from being processed.
Comment 1 Dan Glastonbury 2022-07-14 19:02:08 PDT 
rdar://96709463
Comment 2 Dan Glastonbury 2022-07-14 19:08:25 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2439
Comment 3 EWS 2022-07-14 20:34:10 PDT 
Committed 252488@main (c277889e5b21): <https://commits.webkit.org/252488@main>

Reviewed commits have been landed. Closing PR #2439 and removing active labels.