Bug 242762 - [ANGLE] Bounds check index buffer generation
Summary: [ANGLE] Bounds check index buffer generation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-14 12:47 PDT by Kyle Piddington
Modified: 2022-07-15 16:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.01 KB, patch)
2022-07-14 12:48 PDT, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch (12.56 KB, patch)
2022-07-14 13:04 PDT, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch (12.98 KB, patch)
2022-07-14 16:53 PDT, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch (12.99 KB, patch)
2022-07-14 17:02 PDT, Kyle Piddington
kpiddington: review?
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2022-07-14 12:47:13 PDT
[ANGLE] Bounds check index buffer generation
Comment 1 Kyle Piddington 2022-07-14 12:48:56 PDT
Created attachment 460902 [details]
Patch
Comment 2 Kyle Piddington 2022-07-14 12:51:22 PDT
<rdar://95875589>
Comment 3 Kyle Piddington 2022-07-14 13:04:23 PDT
Created attachment 460903 [details]
Patch
Comment 4 EWS Watchlist 2022-07-14 13:06:03 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 5 Kyle Piddington 2022-07-14 16:53:58 PDT
Created attachment 460915 [details]
Patch
Comment 6 Kyle Piddington 2022-07-14 17:02:01 PDT
Created attachment 460916 [details]
Patch
Comment 7 Kenneth Russell 2022-07-14 17:04:11 PDT
Dean reviewed one of these earlier patches. But - would you like to migrate to the Github workflow, and upload a pull request for this rather than patches? It's missing the COMMIT_MESSAGE file as is.
Comment 8 Kyle Piddington 2022-07-15 13:49:13 PDT
Made a manual-ish pull request: the pr workflow wasn't quite working for me, probably due to some repository cruft.

https://github.com/WebKit/WebKit/pull/2469
Comment 9 EWS 2022-07-15 16:24:53 PDT
Committed 252526@main (7bf231b1fd35): <https://commits.webkit.org/252526@main>

Reviewed commits have been landed. Closing PR #2469 and removing active labels.
Comment 10 Radar WebKit Bug Importer 2022-07-15 16:25:16 PDT
<rdar://problem/97100061>