RESOLVED FIXED 24275
Broken line edit theming in QtWebKit 
https://bugs.webkit.org/show_bug.cgi?id=24275
Summary Broken line edit theming in QtWebKit
Zack Rusin
Reported 2009-03-01 13:37:23 PST
The line edit theming is broken. It's especially evident in the KDE4 Oxygen style. I hate the idea of having to adjust dimensions of line edits, but I don't see a way around it right now. The issue is that if Qt styles has large borders in the lineedit that go inside the content box we will squeeze the box and make it too small. I'd welcome any ideas on how to handle it. For now I'm going to attach a patch that as I mentioned I'm not a huge fan but which does seem to fix it. In it we adjust the size vertically and horizontally set padding on the element equal to the width of the style painted border.
Attachments
Patch which seems to fix the styling issues (3.83 KB, patch)
2009-03-01 13:38 PST, Zack Rusin 		vestbo: review+
DetailsFormatted DiffDiff
Before the patch (53.10 KB, image/png)
2009-03-01 13:38 PST, Zack Rusin 		no flags
Details
After the patch (52.70 KB, image/png)
2009-03-01 13:39 PST, Zack Rusin 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Zack Rusin
Comment 1 2009-03-01 13:38:14 PST
Created attachment 28147 [details] Patch which seems to fix the styling issues
Zack Rusin
Comment 2 2009-03-01 13:38:43 PST
Created attachment 28148 [details] Before the patch
Zack Rusin
Comment 3 2009-03-01 13:39:04 PST
Created attachment 28149 [details] After the patch
Simon Hausmann
Comment 4 2009-03-02 08:39:36 PST
Tor Arne, could you take a look at this one? Thanks :)
Tor Arne Vestbø
Comment 5 2009-03-02 10:04:55 PST
Comment on attachment 28147 [details] Patch which seems to fix the styling issues Looks good, we do the same trick for buttons (adjusting padding). One small nitpick: > + //this will need ot be regenerated when the style changes Also missing Changelog. No need to resubmit patch though, just fix and re=me. Tor Arne
Simon Hausmann
Comment 6 2009-03-27 10:41:03 PDT
Landed in r42038
Note You need to log in before you can comment on or make changes to this bug.