Bug 24275 - Broken line edit theming in QtWebKit
Summary: Broken line edit theming in QtWebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P1 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-01 13:37 PST by Zack Rusin
Modified: 2009-03-27 10:41 PDT (History)
2 users (show)

See Also:


Attachments
Patch which seems to fix the styling issues (3.83 KB, patch)
2009-03-01 13:38 PST, Zack Rusin
vestbo: review+
Details | Formatted Diff | Diff
Before the patch (53.10 KB, image/png)
2009-03-01 13:38 PST, Zack Rusin
no flags Details
After the patch (52.70 KB, image/png)
2009-03-01 13:39 PST, Zack Rusin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zack Rusin 2009-03-01 13:37:23 PST
The line edit theming is broken. It's especially evident in the KDE4 Oxygen style. 
I hate the idea of having to adjust dimensions of line edits, but I don't see a way around it right now. The issue is that if Qt styles has large borders in the lineedit that go inside the content box we will squeeze the box and make it too small.
I'd welcome any ideas on how to handle it. For now I'm going to attach a patch that as I mentioned I'm not a huge fan but which does seem to fix it.
In it we adjust the size vertically and horizontally set padding on the element equal to the width of the style painted border.
Comment 1 Zack Rusin 2009-03-01 13:38:14 PST
Created attachment 28147 [details]
Patch which seems to fix the styling issues
Comment 2 Zack Rusin 2009-03-01 13:38:43 PST
Created attachment 28148 [details]
Before the patch
Comment 3 Zack Rusin 2009-03-01 13:39:04 PST
Created attachment 28149 [details]
After the patch
Comment 4 Simon Hausmann 2009-03-02 08:39:36 PST
Tor Arne, could you take a look at this one? Thanks :)
Comment 5 Tor Arne Vestbø 2009-03-02 10:04:55 PST
Comment on attachment 28147 [details]
Patch which seems to fix the styling issues

Looks good, we do the same trick for buttons (adjusting padding). 

One small nitpick:

> +    //this will need ot be regenerated when the style changes

Also missing Changelog. No need to resubmit patch though, just fix and re=me. 

Tor Arne
Comment 6 Simon Hausmann 2009-03-27 10:41:03 PDT
Landed in r42038