WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
242597
[Make] Can't set GCC_PREPROCESSOR_ADDITIONS since
252143@main
https://bugs.webkit.org/show_bug.cgi?id=242597
Summary
[Make] Can't set GCC_PREPROCESSOR_ADDITIONS since 252143@main
Elliott Williams
Reported
2022-07-11 11:39:26 PDT
https://commits.webkit.org/252143@main
("Stop passing build settings on the command line to avoid invalidating IDE builds") broke workflows where GCC_PREPROCESSOR_ADDITIONS is set from outside of the Makefile (like in `build-jsc`).
Attachments
Add attachment
proposed patch, testcase, etc.
Elliott Williams
Comment 1
2022-07-11 11:46:55 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2296
EWS
Comment 2
2022-07-11 12:49:05 PDT
Committed
252348@main
(ab59fcd01122): <
https://commits.webkit.org/252348@main
> Reviewed commits have been landed. Closing PR #2296 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-07-11 12:50:19 PDT
<
rdar://problem/96838065
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug