Bug 242584 - Reimplement <!-- webkit-test-runner: lang=something --> without using ProcessPoolConfiguration
Summary: Reimplement <!-- webkit-test-runner: lang=something --> without using Process...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 242581 242827
  Show dependency tree / graph
 
Reported: 2022-07-10 19:16 PDT by Myles C. Maxfield
Modified: 2022-07-18 01:57 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-07-10 19:16:05 PDT 
Reimplement <!-- webkit-test-runner: lang=something --> without using ProcessPoolConfiguration
Comment 1 Myles C. Maxfield 2022-07-10 19:22:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2285
Comment 2 EWS 2022-07-10 21:17:52 PDT 
Committed 252335@main (fb205fb01a08): <https://commits.webkit.org/252335@main>

Reviewed commits have been landed. Closing PR #2285 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-10 21:18:17 PDT 
<rdar://problem/96808977>
Comment 4 Yury Semikhatsky 2022-07-15 14:32:21 PDT 
(In reply to EWS from comment #2)
> Committed 252335@main (fb205fb01a08):
> <https://commits.webkit.org/252335@main>
> 
> Reviewed commits have been landed. Closing PR #2285 and removing active
> labels.

This change breaks public API which we are actively using to run multiple pages with different language settings. Is there going to be a replacement for the old API or what should we do?
Comment 5 Yury Semikhatsky 2022-07-15 14:37:03 PDT 
If the GPU process's language must match that of the WebProcess, would it be possible to spawn separate GPU process for the process pool or maybe have multiple language settings inside the GPU process?
Comment 6 Alexey Proskuryakov 2022-07-15 16:07:08 PDT 
If a public API is now broken, the best next step is to file a new bug about that.