Bug 24257 - WebKitCSSMatrix does not have a prototype property
Summary: WebKitCSSMatrix does not have a prototype property
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
Depends on:
Reported: 2009-02-27 18:00 PST by Chris Marrin
Modified: 2009-03-03 10:51 PST (History)
3 users (show)

See Also:

Patch with test (18.43 KB, patch)
2009-03-02 17:47 PST, Chris Marrin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-02-27 18:00:59 PST
Doing WebKitCSSMatrix.prototype returns undefined. This works for all the other native JS classes.
Comment 1 Simon Fraser (smfr) 2009-03-02 12:47:14 PST
WebKitCSSMatrix and WebKitPoint need to be added to the list of global constructors in DOMWindow.idl.
Comment 2 Chris Marrin 2009-03-02 17:47:42 PST
Created attachment 28209 [details]
Patch with test
Comment 3 Sam Weinig 2009-03-02 17:50:01 PST
Comment on attachment 28209 [details]
Patch with test

> +++ WebCore/bindings/js/JSImageConstructor.cpp	(working copy)
> @@ -21,6 +21,7 @@
>  #include "JSImageConstructor.h"
>  #include "HTMLImageElement.h"
> +#include "JSHTMLImageElement.h"
>  #include "HTMLNames.h"
>  #include "JSNode.h"
>  #include "ScriptExecutionContext.h"

These should be sorted.

Comment 4 Chris Marrin 2009-03-03 10:51:20 PST
Sending        LayoutTests/ChangeLog
Adding         LayoutTests/fast/dom/Window/custom-constructors-expected.txt
Adding         LayoutTests/fast/dom/Window/custom-constructors.html
Sending        LayoutTests/fast/dom/Window/window-properties-expected.txt
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/js/JSAudioConstructor.cpp
Sending        WebCore/bindings/js/JSDOMWindowBase.cpp
Sending        WebCore/bindings/js/JSImageConstructor.cpp
Sending        WebCore/bindings/js/JSOptionConstructor.cpp
Sending        WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp
Sending        WebCore/bindings/js/JSWebKitCSSMatrixConstructor.h
Sending        WebCore/bindings/js/JSWebKitPointConstructor.cpp
Sending        WebCore/bindings/js/JSWorkerConstructor.cpp
Transmitting file data .............
Committed revision 41396.