Bug 24256 – Add a preference flag to force software animation

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Marrin]

A flag to always force software animation, even when accelerated compositing is enabled would be useful in testing.

[Chris Marrin]

Created attachment 28107 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 28107 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 41308)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,19 @@
> [phone]  Chris Marrin  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=24256
> +
> +        Added a WebCoreForceSoftwareAnimation flag.
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED

Remove this before committing.

> Index: WebCore/platform/graphics/mac/GraphicsLayerCA.mm
> ===================================================================

> +static bool forceSoftwareAnimation()
> +{
> +    static int forceSoftwareAnimation = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebCoreForceSoftwareAnimation"];
> +    return forceSoftwareAnimation;
> +}

Feel free to change this and the other static ints to static bools. I have no idea why they are ints.

r=me with those changes.

[Chris Marrin]

Sending        WebCore/ChangeLog
Sending        WebCore/platform/graphics/mac/GraphicsLayerCA.mm
Transmitting file data ..
Committed revision 41397.