Bug 24256 - Add a preference flag to force software animation
Summary: Add a preference flag to force software animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-27 16:26 PST by Chris Marrin
Modified: 2009-03-03 10:55 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2009-02-27 16:41 PST, Chris Marrin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2009-02-27 16:26:55 PST
A flag to always force software animation, even when accelerated compositing is enabled would be useful in testing.
Comment 1 Chris Marrin 2009-02-27 16:41:46 PST
Created attachment 28107 [details]
Patch
Comment 2 Simon Fraser (smfr) 2009-02-27 16:57:03 PST
Comment on attachment 28107 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 41308)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,19 @@
> +2009-02-27  Chris Marrin  <cmarrin@apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=24256
> +
> +        Added a WebCoreForceSoftwareAnimation flag.
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED

Remove this before committing.

> Index: WebCore/platform/graphics/mac/GraphicsLayerCA.mm
> ===================================================================

> +static bool forceSoftwareAnimation()
> +{
> +    static int forceSoftwareAnimation = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebCoreForceSoftwareAnimation"];
> +    return forceSoftwareAnimation;
> +}

Feel free to change this and the other static ints to static bools. I have no idea why they are ints.

r=me with those changes.
Comment 3 Chris Marrin 2009-03-03 10:55:50 PST
Sending        WebCore/ChangeLog
Sending        WebCore/platform/graphics/mac/GraphicsLayerCA.mm
Transmitting file data ..
Committed revision 41397.