Bug 24254 - [GTK] spacebar doesn't scroll down
Summary: [GTK] spacebar doesn't scroll down
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-02-27 16:05 PST by Emilio Pozuelo Monfort
Modified: 2009-03-12 06:22 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (1.97 KB, patch)
2009-03-11 20:34 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
proposed fix (1.98 KB, patch)
2009-03-12 05:17 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
makes space scroll down, and shift+space scroll up (2.00 KB, patch)
2009-03-12 06:05 PDT, Gustavo Noronha (kov) 		alp: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Pozuelo Monfort 2009-02-27 16:05:26 PST 
Pressing space on webkit should scroll down the webview, but for the GTK port it doesn't.
Comment 1 Gustavo Noronha (kov) 2009-03-11 20:34:37 PDT 
Created attachment 28518 [details]
proposed fix

It seems to me like we should look forward to do some rework on our scrolling code as a whole. I know Xan has been doing an awesome work on this front, but maybe we need to look at the big picture a bit more.
Comment 2 Gustavo Noronha (kov) 2009-03-12 05:17:33 PDT 
Created attachment 28524 [details]
proposed fix

Addressing comments by alp and xan on IRC.
Comment 3 Gustavo Noronha (kov) 2009-03-12 06:05:56 PDT 
Created attachment 28526 [details]
makes space scroll down, and shift+space scroll up

Addressed more comments by Xan on IRC.
Comment 4 Alp Toker 2009-03-12 06:12:29 PDT 
Comment on attachment 28526 [details]
makes space scroll down, and shift+space scroll up

r=me but please fix the ChangeLog entry to not mention backspace
Comment 5 Gustavo Noronha (kov) 2009-03-12 06:22:57 PDT 
Landed as r41622.