Bug 242369 - [git-webkit] When run git-webkit pr with a revert commit have an error: AttributeError: 'PullRequest' object has no attribute 'link'
Summary: [git-webkit] When run git-webkit pr with a revert commit have an error: Attri...
Status: RESOLVED DUPLICATE of bug 245675
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency treegraph
 
Reported: 2022-07-05 16:48 PDT by Zhifei Fang
Modified: 2023-01-18 11:22 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2022-07-05 16:48:26 PDT
[git-webkit] When run git-webkit pr with a revert commit, it raises an error

ntim @ OpenSource ⚡️ git-webkit pr
Branch 'main' set up to track remote branch 'main' from 'origin'.
Total errors found: 0 in 60 files
Enumerating objects: 1244, done.
Counting objects: 100% (1244/1244), done.
Delta compression using up to 8 threads
Compressing objects: 100% (502/502), done.
Writing objects: 100% (869/869), 325.18 KiB | 218.00 KiB/s, done.
Total 869 (delta 737), reused 472 (delta 361), pack-reused 0
remote: Resolving deltas: 100% (737/737), completed with 346 local objects.
remote: 
remote: Create a pull request for 'revert-user-select-unprefixing' on GitHub by visiting:
remote:      https://github.com/nt1m/WebKit/pull/new/revert-user-select-unprefixing
remote: 
To github.com:nt1m/WebKit.git
 * [new branch]                revert-user-select-unprefixing -> revert-user-select-unprefixing
Created 'PR 2102 | Revert 249800@main: "Unprefix -webkit-user-select"'!
Traceback (most recent call last):
  File "/Volumes/Data/Code/Safari/Internal/Tools/Scripts/git-webkit", line 89, in <module>
    sys.exit(program.main(
  File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 148, in main
    return parsed.main(
  File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 460, in main
    return cls.create_pull_request(repository, args, branch_point)
  File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 402, in create_pull_request
    cls.add_comment_to_reverted_commit_bug_tracker(repository, args, pr, commits[0])
  File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 259, in add_comment_to_reverted_commit_bug_tracker
    tracker.add_comment('Reverted by {}'.format(pr.link))
AttributeError: 'PullRequest' object has no attribute 'link'
Comment 1 Radar WebKit Bug Importer 2022-07-12 16:49:14 PDT
<rdar://problem/96917985>
Comment 2 Jonathan Bedard 2023-01-18 11:22:47 PST
Fixed this in https://bugs.webkit.org/show_bug.cgi?id=245675.

*** This bug has been marked as a duplicate of bug 245675 ***