Bug 242353 - Add const to some fields that are meant to be immutable after construction.
Summary: Add const to some fields that are meant to be immutable after construction.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-05 12:30 PDT by Mark Lam
Modified: 2022-07-05 20:37 PDT (History)
1 user (show)

See Also:

Attachments
EWS testing. (33.86 KB, patch)
2022-07-05 17:14 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Test for gtk EWS. (600 bytes, patch)
2022-07-05 19:21 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-07-05 12:30:57 PDT 
This helps provides a hint to the compiler that a previously fetched constant field need not be re-fetched.  Secondly, it documents for the reader that the intention that the field will not change after construction.
Comment 1 Mark Lam 2022-07-05 12:34:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2086
Comment 2 Mark Lam 2022-07-05 17:14:46 PDT 
Created attachment 460695 [details]
EWS testing.
Comment 3 Mark Lam 2022-07-05 19:21:03 PDT 
Created attachment 460700 [details]
Test for gtk EWS.
Comment 4 EWS 2022-07-05 20:36:25 PDT 
Committed 252168@main (7433e6a2671b): <https://commits.webkit.org/252168@main>

Reviewed commits have been landed. Closing PR #2086 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2022-07-05 20:37:14 PDT 
<rdar://problem/96489199>