NEW 242318
git-webkit upload should amend the commit instead of making a new commit 
https://bugs.webkit.org/show_bug.cgi?id=242318
Summary git-webkit upload should amend the commit instead of making a new commit
Ryosuke Niwa
Reported 2022-07-04 12:30:51 PDT
git-webkit upload should amend the commit instead of trying to create a new commit in each invocation. Looks like this option exists but not enabled by default? --amend.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-07-05 19:20:30 PDT
There isn't consensus on the right behavior yet - some people prefer additional changes to be separate commits to make reviewing easier. And then squash before landing.
Ryosuke Niwa
Comment 2 2022-07-05 20:29:34 PDT
(In reply to Alexey Proskuryakov from comment #1) > There isn't consensus on the right behavior yet - some people prefer > additional changes to be separate commits to make reviewing easier. And then > squash before landing. Maybe this should be configurable during setup?
Radar WebKit Bug Importer
Comment 3 2022-07-11 12:31:16 PDT
<rdar://problem/96837043>
Ryosuke Niwa
Comment 4 2022-07-16 21:34:08 PDT
So... apparently merge-queue can't land a PR unless all commits are squashed so the current behavior of git-webkit upload is incompatible with merge queue.
Note You need to log in before you can comment on or make changes to this bug.