Bug 242318 - git-webkit upload should amend the commit instead of making a new commit
Summary: git-webkit upload should amend the commit instead of making a new commit
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-07-04 12:30 PDT by Ryosuke Niwa
Modified: 2023-01-18 11:24 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-07-04 12:30:51 PDT 
git-webkit upload should amend the commit instead of trying to create a new commit in each invocation.

Looks like this option exists but not enabled by default? --amend.
Comment 1 Alexey Proskuryakov 2022-07-05 19:20:30 PDT 
There isn't consensus on the right behavior yet - some people prefer additional changes to be separate commits to make reviewing easier. And then squash before landing.
Comment 2 Ryosuke Niwa 2022-07-05 20:29:34 PDT 
(In reply to Alexey Proskuryakov from comment #1)
> There isn't consensus on the right behavior yet - some people prefer
> additional changes to be separate commits to make reviewing easier. And then
> squash before landing.

Maybe this should be configurable during setup?
Comment 3 Radar WebKit Bug Importer 2022-07-11 12:31:16 PDT 
<rdar://problem/96837043>
Comment 4 Ryosuke Niwa 2022-07-16 21:34:08 PDT 
So... apparently merge-queue can't land a PR unless all commits are squashed so the current behavior of git-webkit upload is incompatible with merge queue.