Bug 242230 – REGRESSION(250469@main) svg/animations/animation-leak-list-property-instances.html is randomly failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Fujii Hironori]

REGRESSION(250469@main) svg/animations/animation-leak-list-property-instances.html is randomly failing

https://results.webkit.org/?suite=layout-tests&test=svg%2Fanimations%2Fanimation-leak-list-property-instances.html

Since 250469@main (bug#240112) modified animation-leak-list-property-instances.html.

[Fujii Hironori]

250480@main
Buildbot: builder Apple-BigSur-Debug-WK2-Tests build 6491
https://build.webkit.org/#/builders/23/builds/6491

--- /Volumes/Data/worker/Apple-BigSur-Debug-WK2-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-expected.txt
+++ /Volumes/Data/worker/Apple-BigSur-Debug-WK2-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-actual.txt
@@ -3,5 +3,5 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS 0 is 0
+FAIL -63 should be 0. Was -63.

[Fujii Hironori]

Another test failure.

Buildbot: builder GTK-Linux-64-bit-Release-Skip-Failing-Tests build 6406: 252088@main
https://build.webkit.org/#/builders/199/builds/6406

--- /home/buildbot/worker/GTK-Linux-64-bit-Release-Skip-Failing-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-expected.txt
+++ /home/buildbot/worker/GTK-Linux-64-bit-Release-Skip-Failing-Tests/build/layout-test-results/svg/animations/animation-leak-list-property-instances-actual.txt
@@ -3,8 +3,9 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS 0 is 0
+FAIL -7 should be 0. Was -7.
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE

[Alexey Proskuryakov]

Bug 242231 fixed some obviously mistakes in the test, but now it's failing for apparently more substantial reasons.

[Radar WebKit Bug Importer]

<rdar://problem/96403351>

[Fujii Hironori]

Created attachment 460659 [details]
Patch

[Darin Adler]

Comment on attachment 460659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460659&action=review

> LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:6
> +PASS 0 is <= 5

This won’t work to make the test less flaky. Because if we have 1 this line will say "Pass 1 is <= 5" and the test will fail.

[Darin Adler]

Comment on attachment 460659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460659&action=review

>> LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:6
>> +PASS 0 is <= 5
> 
> This won’t work to make the test less flaky. Because if we have 1 this line will say "Pass 1 is <= 5" and the test will fail.

This needs to be changed so that the number of objects is not logged.

[Fujii Hironori]

Comment on attachment 460659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460659&action=review

>>> LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt:6
>>> +PASS 0 is <= 5
>> 
>> This won’t work to make the test less flaky. Because if we have 1 this line will say "Pass 1 is <= 5" and the test will fail.
> 
> This needs to be changed so that the number of objects is not logged.

Good catch. Will fix. Thank you very much.

[Fujii Hironori]

Created attachment 460669 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 460669 [details]
Patch

r=me

[EWS]

Committed 252153@main (1b783a18fdac): <https://commits.webkit.org/252153@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460669 [details].