Bug 242217 - [WPE][GTK] web process leak if webkit_download_set_destination is called with empty destination
Summary: [WPE][GTK] web process leak if webkit_download_set_destination is called with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords: InRadar
Depends on:
Blocks: 241583
  Show dependency tree / graph
 
Reported: 2022-06-30 16:45 PDT by Yury Semikhatsky
Modified: 2022-11-16 09:01 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2022-06-30 16:45:22 PDT 
Passing empty string as the destination according to the current logic in NetworkProcess::findPendingDownloadLocation[1] should cancel the download. In practice the download never finishes and if the browser stays open for > 30s after the page is closed corresponding web process may leak similar to https://bugs.webkit.org/show_bug.cgi?id=241583 (I didn't debug the exact retention path).


[1] https://github.com/WebKit/WebKit/blob/fcd1d36de2ca84f2d8736165fbc08cd6251f9578/Source/WebKit/NetworkProcess/NetworkProcess.cpp#L2042-L2043
Comment 1 Yury Semikhatsky 2022-06-30 16:55:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1970
Comment 2 EWS 2022-11-16 09:00:20 PST 
Committed 256737@main (c985acc37157): <https://commits.webkit.org/256737@main>

Reviewed commits have been landed. Closing PR #1970 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-11-16 09:01:23 PST 
<rdar://problem/102422549>